[v7,19/20] test-cd-emu: Make sure we can call spice_usb_backend_channel_flush_writes

Submitted by Victor Toso on Sept. 16, 2019, 10:21 a.m.

Details

Message ID 20190916102104.20943-20-victortoso@redhat.com
State Superseded
Headers show
Series "added feature of sharing CD image" ( rev: 9 ) in Spice

Not browsing as part of any series.

Commit Message

Victor Toso Sept. 16, 2019, 10:21 a.m.
From: Frediano Ziglio <fziglio@redhat.com>

Currently we call this function when the SPICE channel is up
however this function should continue to work as in theory
the channel could avoid to handle the message and stop the flow
(for instance to implement some kind of flow limitation)
and so will need to call this function again.
This was failing in the first USB emulation implementation
causing a crash.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 tests/cd-emu.c | 4 ++++
 1 file changed, 4 insertions(+)

Patch hide | download patch | download mbox

diff --git a/tests/cd-emu.c b/tests/cd-emu.c
index fb023a9..690423b 100644
--- a/tests/cd-emu.c
+++ b/tests/cd-emu.c
@@ -164,6 +164,10 @@  device_iteration(const int loop, const bool attach_on_connect)
     g_assert_cmpint(hellos_sent, ==, hellos_expected);
     g_assert_cmpint(messages_sent, >=, messages_expected);
 
+    spice_usb_backend_channel_flush_writes(usb_ch);
+    g_assert_cmpint(hellos_sent, ==, hellos_expected);
+    g_assert_cmpint(messages_sent, >=, messages_expected);
+
     // send hello reply
     if (loop == 0) {
         DATA_START