[v2,32/37] panfrost: Kill the explicit serialization in panfrost_batch_submit()

Submitted by Boris Brezillon on Sept. 16, 2019, 9:37 a.m.

Details

Message ID 20190916093715.32203-33-boris.brezillon@collabora.com
State New
Headers show
Series "panfrost: Support batch pipelining" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Boris Brezillon Sept. 16, 2019, 9:37 a.m.
Now that we have all the pieces in place to support pipelining batches
we can get rid of the drmSyncobjWait() at the end of
panfrost_batch_submit().

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
---
 src/gallium/drivers/panfrost/pan_job.c | 9 ---------
 1 file changed, 9 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/gallium/drivers/panfrost/pan_job.c b/src/gallium/drivers/panfrost/pan_job.c
index de2922a8366e..df92b791a1f2 100644
--- a/src/gallium/drivers/panfrost/pan_job.c
+++ b/src/gallium/drivers/panfrost/pan_job.c
@@ -846,7 +846,6 @@  panfrost_batch_submit(struct panfrost_batch *batch)
                         panfrost_batch_submit((*dep)->batch);
         }
 
-        struct panfrost_context *ctx = batch->ctx;
         int ret;
 
         /* Nothing to do! */
@@ -865,15 +864,7 @@  panfrost_batch_submit(struct panfrost_batch *batch)
 
 out:
         panfrost_freeze_batch(batch);
-
-        /* We always stall the pipeline for correct results since pipelined
-         * rendering is quite broken right now (to be fixed by the panfrost_job
-         * refactor, just take the perf hit for correctness)
-         */
-        drmSyncobjWait(pan_screen(ctx->base.screen)->fd,
-                       &batch->out_sync->syncobj, 1, INT64_MAX, 0, NULL);
         panfrost_free_batch(batch);
-
 }
 
 void

Comments

R-b with enthusiasm :)

On Mon, Sep 16, 2019 at 11:37:10AM +0200, Boris Brezillon wrote:
> Now that we have all the pieces in place to support pipelining batches
> we can get rid of the drmSyncobjWait() at the end of
> panfrost_batch_submit().
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
>  src/gallium/drivers/panfrost/pan_job.c | 9 ---------
>  1 file changed, 9 deletions(-)
> 
> diff --git a/src/gallium/drivers/panfrost/pan_job.c b/src/gallium/drivers/panfrost/pan_job.c
> index de2922a8366e..df92b791a1f2 100644
> --- a/src/gallium/drivers/panfrost/pan_job.c
> +++ b/src/gallium/drivers/panfrost/pan_job.c
> @@ -846,7 +846,6 @@ panfrost_batch_submit(struct panfrost_batch *batch)
>                          panfrost_batch_submit((*dep)->batch);
>          }
>  
> -        struct panfrost_context *ctx = batch->ctx;
>          int ret;
>  
>          /* Nothing to do! */
> @@ -865,15 +864,7 @@ panfrost_batch_submit(struct panfrost_batch *batch)
>  
>  out:
>          panfrost_freeze_batch(batch);
> -
> -        /* We always stall the pipeline for correct results since pipelined
> -         * rendering is quite broken right now (to be fixed by the panfrost_job
> -         * refactor, just take the perf hit for correctness)
> -         */
> -        drmSyncobjWait(pan_screen(ctx->base.screen)->fd,
> -                       &batch->out_sync->syncobj, 1, INT64_MAX, 0, NULL);
>          panfrost_free_batch(batch);
> -
>  }
>  
>  void
> -- 
> 2.21.0