[v2,12/37] panfrost: Don't check if BO is mmaped before calling panfrost_bo_mmap()

Submitted by Boris Brezillon on Sept. 16, 2019, 9:36 a.m.

Details

Message ID 20190916093715.32203-13-boris.brezillon@collabora.com
State Accepted
Commit 10ce751726e91164538dff4d380d5568574c6963
Headers show
Series "panfrost: Support batch pipelining" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Boris Brezillon Sept. 16, 2019, 9:36 a.m. 
panfrost_bo_mmap() already takes care of that.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
---
 src/gallium/drivers/panfrost/pan_resource.c | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

Patch hide | download patch | download mbox 

diff --git a/src/gallium/drivers/panfrost/pan_resource.c b/src/gallium/drivers/panfrost/pan_resource.c
index 97ab2f9d9a4e..7083ee37bae2 100644
--- a/src/gallium/drivers/panfrost/pan_resource.c
+++ b/src/gallium/drivers/panfrost/pan_resource.c
@@ -561,11 +561,7 @@  panfrost_transfer_map(struct pipe_context *pctx,
         *out_transfer = &transfer->base;
 
         /* If we haven't already mmaped, now's the time */
-
-        if (!bo->cpu) {
-                struct panfrost_screen *screen = pan_screen(pctx->screen);
-                panfrost_bo_mmap(screen, bo);
-        }
+        panfrost_bo_mmap(pan_screen(pctx->screen), bo);
 
         /* Check if we're bound for rendering and this is a read pixels. If so,
          * we need to flush */

Comments

Alyssa Rosenzweig Sept. 16, 2019, 12:25 p.m. 
R-b

On Mon, Sep 16, 2019 at 11:36:50AM +0200, Boris Brezillon wrote:
> panfrost_bo_mmap() already takes care of that.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
>  src/gallium/drivers/panfrost/pan_resource.c | 6 +-----
>  1 file changed, 1 insertion(+), 5 deletions(-)
> 
> diff --git a/src/gallium/drivers/panfrost/pan_resource.c b/src/gallium/drivers/panfrost/pan_resource.c
> index 97ab2f9d9a4e..7083ee37bae2 100644
> --- a/src/gallium/drivers/panfrost/pan_resource.c
> +++ b/src/gallium/drivers/panfrost/pan_resource.c
> @@ -561,11 +561,7 @@ panfrost_transfer_map(struct pipe_context *pctx,
>          *out_transfer = &transfer->base;
>  
>          /* If we haven't already mmaped, now's the time */
> -
> -        if (!bo->cpu) {
> -                struct panfrost_screen *screen = pan_screen(pctx->screen);
> -                panfrost_bo_mmap(screen, bo);
> -        }
> +        panfrost_bo_mmap(pan_screen(pctx->screen), bo);
>  
>          /* Check if we're bound for rendering and this is a read pixels. If so,
>           * we need to flush */
> -- 
> 2.21.0