[v2,02/37] panfrost: Use the correct type for the bo_handle array

Submitted by Boris Brezillon on Sept. 16, 2019, 9:36 a.m.

Details

Message ID 20190916093715.32203-3-boris.brezillon@collabora.com
State Accepted
Commit a94d0280652d534d379111e1bf164450079510cf
Headers show
Series "panfrost: Support batch pipelining" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Boris Brezillon Sept. 16, 2019, 9:36 a.m.
The DRM driver expects an array of u32, let's use the correct type, even
if using an int works in practice because it's still a 32-bit integer.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
---
 src/gallium/drivers/panfrost/pan_drm.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c
index 8b8e38f03809..ada6221850c0 100644
--- a/src/gallium/drivers/panfrost/pan_drm.c
+++ b/src/gallium/drivers/panfrost/pan_drm.c
@@ -232,7 +232,8 @@  panfrost_drm_submit_batch(struct panfrost_batch *batch, u64 first_job_desc,
         struct pipe_context *gallium = (struct pipe_context *) ctx;
         struct panfrost_screen *screen = pan_screen(gallium->screen);
         struct drm_panfrost_submit submit = {0,};
-        int *bo_handles, ret;
+        uint32_t *bo_handles;
+        int ret;
 
         submit.in_syncs = (u64) (uintptr_t) &ctx->out_sync;
         submit.in_sync_count = 1;

Comments

Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>

On Mon, Sep 16, 2019 at 11:36:40AM +0200, Boris Brezillon wrote:
> The DRM driver expects an array of u32, let's use the correct type, even
> if using an int works in practice because it's still a 32-bit integer.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
>  src/gallium/drivers/panfrost/pan_drm.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/panfrost/pan_drm.c b/src/gallium/drivers/panfrost/pan_drm.c
> index 8b8e38f03809..ada6221850c0 100644
> --- a/src/gallium/drivers/panfrost/pan_drm.c
> +++ b/src/gallium/drivers/panfrost/pan_drm.c
> @@ -232,7 +232,8 @@ panfrost_drm_submit_batch(struct panfrost_batch *batch, u64 first_job_desc,
>          struct pipe_context *gallium = (struct pipe_context *) ctx;
>          struct panfrost_screen *screen = pan_screen(gallium->screen);
>          struct drm_panfrost_submit submit = {0,};
> -        int *bo_handles, ret;
> +        uint32_t *bo_handles;
> +        int ret;
>  
>          submit.in_syncs = (u64) (uintptr_t) &ctx->out_sync;
>          submit.in_sync_count = 1;
> -- 
> 2.21.0