arb_texture_view-sampling-2d-array-as-cubemap: Probe the correct rectangle

Submitted by Jason Ekstrand on Sept. 4, 2014, 10:43 p.m.

Details

Message ID 1409870599-17229-1-git-send-email-jason.ekstrand@intel.com
State New
Headers show

Not browsing as part of any series.

Commit Message

Jason Ekstrand Sept. 4, 2014, 10:43 p.m.
Signed-off-by: Jason Ekstrand <jason.ekstrand@intel.com>
Cc: Ilia Mirkin <imirkin@alum.mit.edu>

---
 tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c b/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
index 2366d0c..987c797 100644
--- a/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
+++ b/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
@@ -52,7 +52,7 @@  piglit_display(void)
 
 	piglit_draw_rect(-1, -1, 2, 2);
 
-	pass = piglit_probe_rect_rgba(-1, -1, 2, 2, green);
+	pass = piglit_probe_rect_rgba(0, 0, piglit_width, piglit_height, green);
 
 	piglit_present_results();
 

Comments

I believe ChrisF already fixed that in 25a322ccfd ("arb_texture_view:
Fix bogus probe rects"). Or am I missing something?

On Thu, Sep 4, 2014 at 6:43 PM, Jason Ekstrand <jason@jlekstrand.net> wrote:
> Signed-off-by: Jason Ekstrand <jason.ekstrand@intel.com>
> Cc: Ilia Mirkin <imirkin@alum.mit.edu>
>
> ---
>  tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c b/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
> index 2366d0c..987c797 100644
> --- a/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
> +++ b/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
> @@ -52,7 +52,7 @@ piglit_display(void)
>
>         piglit_draw_rect(-1, -1, 2, 2);
>
> -       pass = piglit_probe_rect_rgba(-1, -1, 2, 2, green);
> +       pass = piglit_probe_rect_rgba(0, 0, piglit_width, piglit_height, green);
>
>         piglit_present_results();
>
> --
> 2.1.0
>
Yup, thanks.  I missed that in my slightly old piglit checkout
--Jason


On Thu, Sep 4, 2014 at 3:54 PM, Ilia Mirkin <imirkin@alum.mit.edu> wrote:

> I believe ChrisF already fixed that in 25a322ccfd ("arb_texture_view:
> Fix bogus probe rects"). Or am I missing something?
>
> On Thu, Sep 4, 2014 at 6:43 PM, Jason Ekstrand <jason@jlekstrand.net>
> wrote:
> > Signed-off-by: Jason Ekstrand <jason.ekstrand@intel.com>
> > Cc: Ilia Mirkin <imirkin@alum.mit.edu>
> >
> > ---
> >  tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
> b/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
> > index 2366d0c..987c797 100644
> > --- a/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
> > +++ b/tests/spec/arb_texture_view/sampling-2d-array-as-cubemap.c
> > @@ -52,7 +52,7 @@ piglit_display(void)
> >
> >         piglit_draw_rect(-1, -1, 2, 2);
> >
> > -       pass = piglit_probe_rect_rgba(-1, -1, 2, 2, green);
> > +       pass = piglit_probe_rect_rgba(0, 0, piglit_width, piglit_height,
> green);
> >
> >         piglit_present_results();
> >
> > --
> > 2.1.0
> >
>