[v2,2/3] drm/mgag200: Rename constant MGAREG_Status to MGAREG_STATUS

Submitted by Thomas Zimmermann on Sept. 12, 2019, 6:42 a.m.

Details

Message ID 20190912064230.27972-3-tzimmermann@suse.de
State New
Headers show
Series "Rate-limit shadow-FB-to-console-update to screen refresh" ( rev: 2 ) in DRI devel

Not browsing as part of any series.

Commit Message

Thomas Zimmermann Sept. 12, 2019, 6:42 a.m.
Register constants are upper case. Fix MGAREG_Status accordingly.

Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
 drivers/gpu/drm/mgag200/mgag200_mode.c | 6 +++---
 drivers/gpu/drm/mgag200/mgag200_reg.h  | 2 +-
 2 files changed, 4 insertions(+), 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
index 5e778b5f1a10..302ba40eb033 100644
--- a/drivers/gpu/drm/mgag200/mgag200_mode.c
+++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
@@ -79,12 +79,12 @@  static inline void mga_wait_vsync(struct mga_device *mdev)
 	unsigned int status = 0;
 
 	do {
-		status = RREG32(MGAREG_Status);
+		status = RREG32(MGAREG_STATUS);
 	} while ((status & 0x08) && time_before(jiffies, timeout));
 	timeout = jiffies + HZ/10;
 	status = 0;
 	do {
-		status = RREG32(MGAREG_Status);
+		status = RREG32(MGAREG_STATUS);
 	} while (!(status & 0x08) && time_before(jiffies, timeout));
 }
 
@@ -93,7 +93,7 @@  static inline void mga_wait_busy(struct mga_device *mdev)
 	unsigned long timeout = jiffies + HZ;
 	unsigned int status = 0;
 	do {
-		status = RREG8(MGAREG_Status + 2);
+		status = RREG8(MGAREG_STATUS + 2);
 	} while ((status & 0x01) && time_before(jiffies, timeout));
 }
 
diff --git a/drivers/gpu/drm/mgag200/mgag200_reg.h b/drivers/gpu/drm/mgag200/mgag200_reg.h
index c096a9d6bcbc..6c460d9a2143 100644
--- a/drivers/gpu/drm/mgag200/mgag200_reg.h
+++ b/drivers/gpu/drm/mgag200/mgag200_reg.h
@@ -101,7 +101,7 @@ 
 #define MGAREG_EXEC		0x0100
 
 #define	MGAREG_FIFOSTATUS	0x1e10
-#define	MGAREG_Status		0x1e14
+#define	MGAREG_STATUS		0x1e14
 #define MGAREG_CACHEFLUSH       0x1fff
 #define	MGAREG_ICLEAR		0x1e18
 #define	MGAREG_IEN		0x1e1c

Comments

On Thu, Sep 12, 2019 at 08:42:29AM +0200, Thomas Zimmermann wrote:
> Register constants are upper case. Fix MGAREG_Status accordingly.
> 
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>

Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>

> ---
>  drivers/gpu/drm/mgag200/mgag200_mode.c | 6 +++---
>  drivers/gpu/drm/mgag200/mgag200_reg.h  | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/mgag200/mgag200_mode.c b/drivers/gpu/drm/mgag200/mgag200_mode.c
> index 5e778b5f1a10..302ba40eb033 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_mode.c
> +++ b/drivers/gpu/drm/mgag200/mgag200_mode.c
> @@ -79,12 +79,12 @@ static inline void mga_wait_vsync(struct mga_device *mdev)
>  	unsigned int status = 0;
>  
>  	do {
> -		status = RREG32(MGAREG_Status);
> +		status = RREG32(MGAREG_STATUS);
>  	} while ((status & 0x08) && time_before(jiffies, timeout));
>  	timeout = jiffies + HZ/10;
>  	status = 0;
>  	do {
> -		status = RREG32(MGAREG_Status);
> +		status = RREG32(MGAREG_STATUS);
>  	} while (!(status & 0x08) && time_before(jiffies, timeout));
>  }
>  
> @@ -93,7 +93,7 @@ static inline void mga_wait_busy(struct mga_device *mdev)
>  	unsigned long timeout = jiffies + HZ;
>  	unsigned int status = 0;
>  	do {
> -		status = RREG8(MGAREG_Status + 2);
> +		status = RREG8(MGAREG_STATUS + 2);
>  	} while ((status & 0x01) && time_before(jiffies, timeout));
>  }
>  
> diff --git a/drivers/gpu/drm/mgag200/mgag200_reg.h b/drivers/gpu/drm/mgag200/mgag200_reg.h
> index c096a9d6bcbc..6c460d9a2143 100644
> --- a/drivers/gpu/drm/mgag200/mgag200_reg.h
> +++ b/drivers/gpu/drm/mgag200/mgag200_reg.h
> @@ -101,7 +101,7 @@
>  #define MGAREG_EXEC		0x0100
>  
>  #define	MGAREG_FIFOSTATUS	0x1e10
> -#define	MGAREG_Status		0x1e14
> +#define	MGAREG_STATUS		0x1e14
>  #define MGAREG_CACHEFLUSH       0x1fff
>  #define	MGAREG_ICLEAR		0x1e18
>  #define	MGAREG_IEN		0x1e1c
> -- 
> 2.23.0
>