[1/4] drm/i915/tgl: Add missing ddi clock select during DP init sequence

Submitted by Souza, Jose on Sept. 12, 2019, 1:10 a.m.

Details

Message ID 20190912011016.8353-1-jose.souza@intel.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Intel GFX

Not browsing as part of any series.

Commit Message

Souza, Jose Sept. 12, 2019, 1:10 a.m.
From: "Taylor, Clinton A" <clinton.a.taylor@intel.com>

Step 4.b was complete missed because it is only required to TC and TBT.

Bspec: 49190
Signed-off-by: Taylor, Clinton A <clinton.a.taylor@intel.com>
---
 drivers/gpu/drm/i915/display/intel_ddi.c | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
index 3e6394139964..81792a04e0aa 100644
--- a/drivers/gpu/drm/i915/display/intel_ddi.c
+++ b/drivers/gpu/drm/i915/display/intel_ddi.c
@@ -3224,11 +3224,14 @@  static void tgl_ddi_pre_enable_dp(struct intel_encoder *encoder,
 	intel_edp_panel_on(intel_dp);
 
 	/*
-	 * 1.b, 3. and 4. is done before tgl_ddi_pre_enable_dp() by:
+	 * 1.b, 3. and 4.a is done before tgl_ddi_pre_enable_dp() by:
 	 * haswell_crtc_enable()->intel_encoders_pre_pll_enable() and
 	 * haswell_crtc_enable()->intel_enable_shared_dpll()
 	 */
 
+	/* 4.b */
+	intel_ddi_clk_select(encoder, crtc_state);
+
 	/* 5. */
 	if (!intel_phy_is_tc(dev_priv, phy) ||
 	    dig_port->tc_mode != TC_PORT_TBT_ALT)

Comments

This series was supersede by 
https://patchwork.freedesktop.org/series/66695/

On Wed, 2019-09-11 at 18:10 -0700, José Roberto de Souza wrote:
> From: "Taylor, Clinton A" <clinton.a.taylor@intel.com>

> 

> Step 4.b was complete missed because it is only required to TC and

> TBT.

> 

> Bspec: 49190

> Signed-off-by: Taylor, Clinton A <clinton.a.taylor@intel.com>

> ---

>  drivers/gpu/drm/i915/display/intel_ddi.c | 5 ++++-

>  1 file changed, 4 insertions(+), 1 deletion(-)

> 

> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c

> b/drivers/gpu/drm/i915/display/intel_ddi.c

> index 3e6394139964..81792a04e0aa 100644

> --- a/drivers/gpu/drm/i915/display/intel_ddi.c

> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c

> @@ -3224,11 +3224,14 @@ static void tgl_ddi_pre_enable_dp(struct

> intel_encoder *encoder,

>  	intel_edp_panel_on(intel_dp);

>  

>  	/*

> -	 * 1.b, 3. and 4. is done before tgl_ddi_pre_enable_dp() by:

> +	 * 1.b, 3. and 4.a is done before tgl_ddi_pre_enable_dp() by:

>  	 * haswell_crtc_enable()->intel_encoders_pre_pll_enable() and

>  	 * haswell_crtc_enable()->intel_enable_shared_dpll()

>  	 */

>  

> +	/* 4.b */

> +	intel_ddi_clk_select(encoder, crtc_state);

> +

>  	/* 5. */

>  	if (!intel_phy_is_tc(dev_priv, phy) ||

>  	    dig_port->tc_mode != TC_PORT_TBT_ALT)