[spice-common] common/recorder.h: do not complain on unused (dummy) recorders

Submitted by Frediano Ziglio on Sept. 11, 2019, 7:43 a.m.

Details

Message ID 392846067.11493336.1568187825565.JavaMail.zimbra@redhat.com
State Superseded
Headers show
Series "common/recorder.h: do not complain on unused (dummy) recorders" ( rev: 2 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio Sept. 11, 2019, 7:43 a.m.
> 
> Signed-off-by: Kevin Pouget <kpouget@redhat.com>

I needed this to compile (maybe different options):



> ---
>  common/recorder.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/common/recorder.h b/common/recorder.h
> index 98b8797..8448e02 100644
> --- a/common/recorder.h
> +++ b/common/recorder.h
> @@ -20,6 +20,7 @@
>  
>  #include <stdio.h>
>  #include <stdint.h>
> +#include <spice/macros.h>
>  
>  /* Replacement declarations.
>   * There declarations should generate no code (beside when no optimization
>   are
> @@ -45,7 +46,7 @@ typedef struct SpiceDummyTweak {
>  #define RECORDER(rec, num_rings, comment) \
>      RECORDER_DEFINE(rec, num_rings, comment)
>  #define RECORDER_DEFINE(rec, num_rings, comment) \
> -    const SpiceEmptyStruct spice_recorder_ ## rec = {}
> +    const SpiceEmptyStruct SPICE_GNUC_UNUSED spice_recorder_ ## rec = {}
>  #define RECORDER_TRACE(rec) \
>      (sizeof(spice_recorder_ ## rec) != sizeof(SpiceEmptyStruct))
>  #define RECORDER_TWEAK_DECLARE(rec) \

Beside that patch looks works for me.

Frediano

Patch hide | download patch | download mbox

diff --git a/tests/Makefile.am b/tests/Makefile.am
index 4b8bcf4..e8766d8 100644
--- a/tests/Makefile.am
+++ b/tests/Makefile.am
@@ -73,6 +73,7 @@  test_dummy_recorder_SOURCES =         \
        $(NULL)
 test_dummy_recorder_CFLAGS =           \
        -I$(top_srcdir)                 \
+       $(PROTOCOL_CFLAGS)              \
        $(NULL)
 test_dummy_recorder_LDADD =                            \
        $(top_builddir)/common/libspice-common.la       \