[spice-gtk] spicy: Do not call gst_init directly

Submitted by Frediano Ziglio on Sept. 10, 2019, 9:21 a.m.

Details

Message ID 20190910092134.19105-1-fziglio@redhat.com
State New
Headers show
Series "spicy: Do not call gst_init directly" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio Sept. 10, 2019, 9:21 a.m.
GStreamer is already initialized using gst_init_get_option_group and
gst_init_get_option_group.

From gst_init documentation:
   WARNING: This function does not work in the same way as
   corresponding functions in other glib-style libraries,
   such as gtk_init(). In particular, unknown command line options
   cause this function to abort program execution.

This luckily is not true (program won't abort if you pass --gst-foo
for instance) but better to stick to documentation.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 tools/spicy.c | 1 -
 1 file changed, 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/tools/spicy.c b/tools/spicy.c
index 403a66d1..8ca62f91 100644
--- a/tools/spicy.c
+++ b/tools/spicy.c
@@ -2017,7 +2017,6 @@  int main(int argc, char *argv[])
 
     /* parse opts */
     gtk_init(&argc, &argv);
-    gst_init(&argc, &argv);
     context = g_option_context_new("- spice client test application");
     g_option_context_set_summary(context, "Gtk+ test client to connect to Spice servers.");
     g_option_context_set_description(context, "Report bugs to " PACKAGE_BUGREPORT ".");