[v3,06/25] panfrost: Get rid of unused panfrost_context fields

Submitted by Boris Brezillon on Sept. 5, 2019, 7:41 p.m.

Details

Message ID 20190905194150.17608-7-boris.brezillon@collabora.com
State Accepted
Commit 2c90045cf27834e80493489668816e3639fc4d83
Headers show
Series "panfrost: Rework the batch pipelining logic" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Boris Brezillon Sept. 5, 2019, 7:41 p.m.
Some fields in panfrost_context are unused (probably leftovers from
previous refactor). Let's get rid of them.

Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
---
 src/gallium/drivers/panfrost/pan_context.h | 4 ----
 1 file changed, 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/gallium/drivers/panfrost/pan_context.h b/src/gallium/drivers/panfrost/pan_context.h
index 8f9cc44fedac..9723d56ac5f7 100644
--- a/src/gallium/drivers/panfrost/pan_context.h
+++ b/src/gallium/drivers/panfrost/pan_context.h
@@ -129,8 +129,6 @@  struct panfrost_context {
         struct panfrost_bo *scratchpad;
         struct panfrost_bo *tiler_heap;
         struct panfrost_bo *tiler_dummy;
-        struct panfrost_memory cmdstream_persistent;
-        struct panfrost_memory depth_stencil_buffer;
 
         bool active_queries;
         uint64_t prims_generated;
@@ -157,8 +155,6 @@  struct panfrost_context {
          * it is disabled, just equal to plain vertex count */
         unsigned padded_count;
 
-        union mali_attr attributes[PIPE_MAX_ATTRIBS];
-
         /* TODO: Multiple uniform buffers (index =/= 0), finer updates? */
 
         struct panfrost_constant_buffer constant_buffer[PIPE_SHADER_TYPES];

Comments

Reviewed-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>

I wish static analysis and friends would identify these automatically.

On Thu, Sep 05, 2019 at 09:41:31PM +0200, Boris Brezillon wrote:
> Some fields in panfrost_context are unused (probably leftovers from
> previous refactor). Let's get rid of them.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@collabora.com>
> ---
>  src/gallium/drivers/panfrost/pan_context.h | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/src/gallium/drivers/panfrost/pan_context.h b/src/gallium/drivers/panfrost/pan_context.h
> index 8f9cc44fedac..9723d56ac5f7 100644
> --- a/src/gallium/drivers/panfrost/pan_context.h
> +++ b/src/gallium/drivers/panfrost/pan_context.h
> @@ -129,8 +129,6 @@ struct panfrost_context {
>          struct panfrost_bo *scratchpad;
>          struct panfrost_bo *tiler_heap;
>          struct panfrost_bo *tiler_dummy;
> -        struct panfrost_memory cmdstream_persistent;
> -        struct panfrost_memory depth_stencil_buffer;
>  
>          bool active_queries;
>          uint64_t prims_generated;
> @@ -157,8 +155,6 @@ struct panfrost_context {
>           * it is disabled, just equal to plain vertex count */
>          unsigned padded_count;
>  
> -        union mali_attr attributes[PIPE_MAX_ATTRIBS];
> -
>          /* TODO: Multiple uniform buffers (index =/= 0), finer updates? */
>  
>          struct panfrost_constant_buffer constant_buffer[PIPE_SHADER_TYPES];
> -- 
> 2.21.0