[1/2] drm/amd/display: bypass stereo programming

Submitted by Liu, Aaron on Sept. 4, 2019, 6:06 a.m.

Details

Message ID 1567577166-18064-1-git-send-email-aaron.liu@amd.com
State New
Headers show
Series "Series without cover letter" ( rev: 2 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Liu, Aaron Sept. 4, 2019, 6:06 a.m.
From: Roman Li <Roman.Li@amd.com>

hack to avoid crash on renoir
should be resolved after upcoming gpio refactoring promotion

Signed-off-by: Roman Li <Roman.Li@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 6 ++++++
 1 file changed, 6 insertions(+)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
index 5b9dd16..ee2186c 100644
--- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c
@@ -2844,6 +2844,12 @@  static void dcn10_setup_stereo(struct pipe_ctx *pipe_ctx, struct dc *dc)
 {
 	struct crtc_stereo_flags flags = { 0 };
 	struct dc_stream_state *stream = pipe_ctx->stream;
+#ifdef CONFIG_DRM_AMD_DC_DCN2_1
+/* TODO: remove after gpio refactor gets promoted
+*        otherwise it causing crash on Renoir
+*/
+	return;
+#endif
 
 	dcn10_config_stereo_parameters(stream, &flags);
 

Comments

On 2019-09-04 2:06 a.m., Liu, Aaron wrote:
> From: Roman Li <Roman.Li@amd.com>

> 

> hack to avoid crash on renoir

> should be resolved after upcoming gpio refactoring promotion

> 

> Signed-off-by: Roman Li <Roman.Li@amd.com>


Nack. This is not the right way to do this upstream. We shouldn't use
compile time guard to change ASIC behavior. This is a bringup-branch
change and needs to be revisited for amd-stg.

Harry

> ---

>  drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c | 6 ++++++

>  1 file changed, 6 insertions(+)

> 

> diff --git a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c

> index 5b9dd16..ee2186c 100644

> --- a/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c

> +++ b/drivers/gpu/drm/amd/display/dc/dcn10/dcn10_hw_sequencer.c

> @@ -2844,6 +2844,12 @@ static void dcn10_setup_stereo(struct pipe_ctx *pipe_ctx, struct dc *dc)

>  {

>  	struct crtc_stereo_flags flags = { 0 };

>  	struct dc_stream_state *stream = pipe_ctx->stream;

> +#ifdef CONFIG_DRM_AMD_DC_DCN2_1

> +/* TODO: remove after gpio refactor gets promoted

> +*        otherwise it causing crash on Renoir

> +*/

> +	return;

> +#endif

>  

>  	dcn10_config_stereo_parameters(stream, &flags);

>  

>