drm/amd/powerplay: Variable ps could be NULL when it get dereferenced

Submitted by Yizhuo on Aug. 30, 2019, 4:35 a.m.

Details

Message ID 20190830043504.23760-1-yzhai003@ucr.edu
State New
Headers show
Series "drm/amd/powerplay: Variable ps could be NULL when it get dereferenced" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Yizhuo Aug. 30, 2019, 4:35 a.m.
Inside function cz_get_performance_level(), pointer ps could be NULL via
cast_const_PhwCzPowerState(). However, this pointer is dereferenced
without any check, which is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
---
 drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c
index bc839ff0bdd0..d2628e7b612d 100644
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c
@@ -1799,6 +1799,9 @@  static int cz_get_performance_level(struct pp_hwmgr *hwmgr, const struct pp_hw_p
 	data = (struct cz_hwmgr *)(hwmgr->backend);
 	ps = cast_const_PhwCzPowerState(state);
 
+	if (!ps)
+		return -EINVAL;
+
 	level_index = index > ps->level - 1 ? ps->level - 1 : index;
 	level->coreClock = ps->levels[level_index].engineClock;