[spice-gtk,v4,14/29] fixup! usb-redir: add implementation of emulated CD device

Submitted by Frediano Ziglio on Aug. 27, 2019, 9:22 a.m.

Details

Message ID 20190827092246.10276-15-fziglio@redhat.com
State Superseded
Headers show
Series "added feature of sharing CD image" ( rev: 6 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio Aug. 27, 2019, 9:22 a.m.
Add comment on constant
---
 src/usb-device-cd.c | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/src/usb-device-cd.c b/src/usb-device-cd.c
index c33bb290..2234289c 100644
--- a/src/usb-device-cd.c
+++ b/src/usb-device-cd.c
@@ -57,6 +57,7 @@  typedef struct SpiceCdLU {
 
 #define MAX_LUN_PER_DEVICE              1
 #define USB2_BCD                        0x200
+/* Red Hat USB VID */
 #define CD_DEV_VID                      0x2b23
 #define CD_DEV_PID                      0xCDCD
 #define CD_DEV_CLASS                    8

Comments


> 
> Hi,
> 
> On Tue, Aug 27, 2019 at 10:22:31AM +0100, Frediano Ziglio wrote:
> > Add comment on constant
> > ---
> >  src/usb-device-cd.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/src/usb-device-cd.c b/src/usb-device-cd.c
> > index c33bb290..2234289c 100644
> > --- a/src/usb-device-cd.c
> > +++ b/src/usb-device-cd.c
> > @@ -57,6 +57,7 @@ typedef struct SpiceCdLU {
> >  
> >  #define MAX_LUN_PER_DEVICE              1
> >  #define USB2_BCD                        0x200
> > +/* Red Hat USB VID */
> 
> I don't mind adding a comment but perhaps SPICE USB VID instead?
> 

No, SPICE is a project, not a vendor, the 0x2b23 is reserved by USB
standards for Red Hat, not for SPICE.
Another reason why the comment make sense :-)

> >  #define CD_DEV_VID                      0x2b23
> >  #define CD_DEV_PID                      0xCDCD
> >  #define CD_DEV_CLASS                    8

Frediano