[5/8] gen_builtin_uniform_tests: Take advantage of draw_rect support for core contexts.

Submitted by Eric Anholt on Aug. 29, 2014, 9:41 p.m.

Details

Message ID 1409348479-15398-5-git-send-email-eric@anholt.net
State New
Headers show

Not browsing as part of any series.

Commit Message

Eric Anholt Aug. 29, 2014, 9:41 p.m.
---
 generated_tests/gen_builtin_uniform_tests.py | 34 ++++++----------------------
 1 file changed, 7 insertions(+), 27 deletions(-)

Patch hide | download patch | download mbox

diff --git a/generated_tests/gen_builtin_uniform_tests.py b/generated_tests/gen_builtin_uniform_tests.py
index 5f87fbe..f9a43cb 100644
--- a/generated_tests/gen_builtin_uniform_tests.py
+++ b/generated_tests/gen_builtin_uniform_tests.py
@@ -358,10 +358,7 @@  class ShaderTest(object):
         return self._signature.version_introduced
 
     def draw_command(self):
-        if self.glsl_version() >= 140:
-            return 'draw arrays GL_TRIANGLE_FAN 0 4\n'
-        else:
-            return 'draw rect -1 -1 2 2\n'
+        return 'draw rect -1 -1 2 2\n'
 
     def make_additional_requirements(self):
         """Return a string that should be included in the test's
@@ -451,21 +448,6 @@  class ShaderTest(object):
                 test_num % 250, test_vector, self.draw_command())
         return test
 
-    def make_vbo_data(self):
-        # Starting with GLSL 1.40/GL 3.1, we need to use VBOs and
-        # vertex shader input bindings for our vertex data instead of
-        # the piglit drawing utilities and gl_Vertex.
-        if self.glsl_version() < 140:
-            return ""
-        vbo = '[vertex data]\n'
-        vbo += 'vertex/float/2\n'
-        vbo += '-1.0 -1.0\n'
-        vbo += ' 1.0 -1.0\n'
-        vbo += ' 1.0  1.0\n'
-        vbo += '-1.0  1.0\n'
-        vbo += '\n'
-        return vbo
-
     def filename(self):
         argtype_names = '-'.join(
             str(argtype) for argtype in self._signature.argtypes)
@@ -503,8 +485,6 @@  class ShaderTest(object):
             shader_test += '\n'
         shader_test += '[fragment shader]\n'
         shader_test += self.make_fragment_shader()
-        shader_test += '\n'
-        shader_test += self.make_vbo_data()
         shader_test += '[test]\n'
         shader_test += self.make_test()
         filename = self.filename()
@@ -525,9 +505,9 @@  class VertexShaderTest(ShaderTest):
     def make_vertex_shader(self):
         if self.glsl_version() >= 140:
             return self.make_test_shader(
-                'in vec4 vertex;\n' +
+                'in vec4 piglit_vertex;\n' +
                 'out vec4 color;\n',
-                '  gl_Position = vertex;\n',
+                '  gl_Position = piglit_vertex;\n',
                 'color', '')
         else:
             return self.make_test_shader(
@@ -558,12 +538,12 @@  class GeometryShaderTest(ShaderTest):
 
     def make_vertex_shader(self):
         shader = ''
-        shader += "in vec4 vertex;\n"
+        shader += "in vec4 piglit_vertex;\n"
         shader += "out vec4 vertex_to_gs;\n"
 
         shader += "void main()\n"
         shader += "{\n"
-        shader += "     vertex_to_gs = vertex;\n"
+        shader += "     vertex_to_gs = piglit_vertex;\n"
         shader += "}\n"
 
         return shader
@@ -606,12 +586,12 @@  class FragmentShaderTest(ShaderTest):
     def make_vertex_shader(self):
         shader = ""
         if self.glsl_version() >= 140:
-            shader += "in vec4 vertex;\n"
+            shader += "in vec4 piglit_vertex;\n"
 
         shader += "void main()\n"
         shader += "{\n"
         if self.glsl_version() >= 140:
-            shader += "        gl_Position = vertex;\n"
+            shader += "        gl_Position = piglit_vertex;\n"
         else:
             shader += "        gl_Position = gl_Vertex;\n"
         shader += "}\n"