[spice-server] stat-file: Use proper macro for container computation

Submitted by Frediano Ziglio on Aug. 22, 2019, 7:30 a.m.

Details

Message ID 20190822073056.12480-1-fziglio@redhat.com
State Accepted
Commit 80bb7eb774ad5a7ae95d7b395841d4c79908be3d
Headers show
Series "stat-file: Use proper macro for container computation" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio Aug. 22, 2019, 7:30 a.m.
This is currently more style patch as the "value" field is the
first field of SpiceStatNode structure, so has offset 0. However
to compute the containing structure it better to use the proper
macro to avoid confusion.
If the offset won't be 0 the subtraction would compute the
wrong pointer as the offset is expressed in bytes but the
element size are uint64_t.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 server/stat-file.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/server/stat-file.c b/server/stat-file.c
index 4228be310..38c393389 100644
--- a/server/stat-file.c
+++ b/server/stat-file.c
@@ -233,6 +233,6 @@  void stat_file_remove_node(RedStatFile *stat_file, StatNodeRef ref)
 
 void stat_file_remove_counter(RedStatFile *stat_file, uint64_t *counter)
 {
-    stat_file_remove(stat_file, (SpiceStatNode *)(counter - SPICE_OFFSETOF(SpiceStatNode, value)));
+    stat_file_remove(stat_file, SPICE_CONTAINEROF(counter, SpiceStatNode, value));
 }
 #endif

Comments