panfrost/ci: Diff results when printing

Submitted by Alyssa Rosenzweig on Aug. 21, 2019, 5:48 p.m.

Details

Message ID 20190821174823.7782-1-alyssa.rosenzweig@collabora.com
State New
Headers show
Series "panfrost/ci: Diff results when printing" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Alyssa Rosenzweig Aug. 21, 2019, 5:48 p.m.
Otherwise, there is too much noise to see what's going on.

Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
---
 src/gallium/drivers/panfrost/ci/deqp-runner.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
index c6b2cce8882..54fa6834ad8 100644
--- a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
+++ b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
@@ -99,7 +99,7 @@  for test in $FLIP_FLOPS; do sed -i "/$test/d" /tmp/case-list.txt; done
 
 if [ $? -ne 0 ]; then
     echo "Regressions detected, printing results:"
-    cat /tmp/results.txt
+    diff /tmp/results.txt /deqp/expected-failures.txt
     echo "deqp: fail"
 else
     echo "No regressions detected"

Comments

On 8/21/19 7:48 PM, Alyssa Rosenzweig wrote:
> Otherwise, there is too much noise to see what's going on.

I'm afraid this doesn't improve things much, as you can see below:

https://gitlab.freedesktop.org/tomeu/mesa/-/jobs/524402

Jakob has kindly offered to add this weekend a mode that prints only 
regressions and improvements. That should match what we had before.

Regards,

Tomeu

> Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
> ---
>   src/gallium/drivers/panfrost/ci/deqp-runner.sh | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> index c6b2cce8882..54fa6834ad8 100644
> --- a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> +++ b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> @@ -99,7 +99,7 @@ for test in $FLIP_FLOPS; do sed -i "/$test/d" /tmp/case-list.txt; done
>   
>   if [ $? -ne 0 ]; then
>       echo "Regressions detected, printing results:"
> -    cat /tmp/results.txt
> +    diff /tmp/results.txt /deqp/expected-failures.txt
>       echo "deqp: fail"
>   else
>       echo "No regressions detected"
>
On Thursday, 2019-08-22 08:22:28 +0200, Tomeu Vizoso wrote:
> On 8/21/19 7:48 PM, Alyssa Rosenzweig wrote:
> > Otherwise, there is too much noise to see what's going on.
> 
> I'm afraid this doesn't improve things much, as you can see below:
> 
> https://gitlab.freedesktop.org/tomeu/mesa/-/jobs/524402

Indeed.

I think using `comm` on sorted inputs might be better?

> 
> Jakob has kindly offered to add this weekend a mode that prints only
> regressions and improvements. That should match what we had before.
> 
> Regards,
> 
> Tomeu
> 
> > Signed-off-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
> > ---
> >   src/gallium/drivers/panfrost/ci/deqp-runner.sh | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/src/gallium/drivers/panfrost/ci/deqp-runner.sh b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> > index c6b2cce8882..54fa6834ad8 100644
> > --- a/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> > +++ b/src/gallium/drivers/panfrost/ci/deqp-runner.sh
> > @@ -99,7 +99,7 @@ for test in $FLIP_FLOPS; do sed -i "/$test/d" /tmp/case-list.txt; done
> >   if [ $? -ne 0 ]; then
> >       echo "Regressions detected, printing results:"
> > -    cat /tmp/results.txt
> > +    diff /tmp/results.txt /deqp/expected-failures.txt
> >       echo "deqp: fail"
> >   else
> >       echo "No regressions detected"
> > 
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev