drm/amd/amdgpu: Modify sdma instance number

Submitted by Gang Ba on Aug. 21, 2019, 2:32 p.m.

Details

Message ID 1566397966-4357-1-git-send-email-gaba@amd.com
State New
Headers show
Series "drm/amd/amdgpu: Modify sdma instance number" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Gang Ba Aug. 21, 2019, 2:32 p.m.
To upgrade performance in small bar mode, set sdma buffer function
ring and pte function ring to use different instance.

Change-Id: Ida6377914eb68a188f745e63409f344f0ce1a8c4
Signed-off-by: Gang Ba <gaba@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
index 071d6c9..5aca9bb4a 100644
--- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
@@ -2500,7 +2500,7 @@  static void sdma_v4_0_set_buffer_funcs(struct amdgpu_device *adev)
 {
 	adev->mman.buffer_funcs = &sdma_v4_0_buffer_funcs;
 	if (adev->sdma.has_page_queue && adev->sdma.num_instances > 1)
-		adev->mman.buffer_funcs_ring = &adev->sdma.instance[1].page;
+		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].page;
 	else
 		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].ring;
 }

Comments

Am 21.08.19 um 16:32 schrieb Gang Ba:
> To upgrade performance in small bar mode, set sdma buffer function
> ring and pte function ring to use different instance.

NAK, we intentionally reserved the first paging queue here.

I wanted to revert that as well, but in this case you would need to 
revert the whole patch and not just this change.

Just look for the patch adding that line and completely revert it instead.

Regards,
Christian.

>
> Change-Id: Ida6377914eb68a188f745e63409f344f0ce1a8c4
> Signed-off-by: Gang Ba <gaba@amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> index 071d6c9..5aca9bb4a 100644
> --- a/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> +++ b/drivers/gpu/drm/amd/amdgpu/sdma_v4_0.c
> @@ -2500,7 +2500,7 @@ static void sdma_v4_0_set_buffer_funcs(struct amdgpu_device *adev)
>   {
>   	adev->mman.buffer_funcs = &sdma_v4_0_buffer_funcs;
>   	if (adev->sdma.has_page_queue && adev->sdma.num_instances > 1)
> -		adev->mman.buffer_funcs_ring = &adev->sdma.instance[1].page;
> +		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].page;
>   	else
>   		adev->mman.buffer_funcs_ring = &adev->sdma.instance[0].ring;
>   }