[spice-gtk,v3,8/9] usb-redir: enable redirection of emulated CD drive

Submitted by Yuri Benditovich on Aug. 12, 2019, 9:57 a.m.

Details

Message ID 20190812095729.32692-9-yuri.benditovich@daynix.com
State Superseded
Headers show
Series "added feature of sharing CD image" ( rev: 5 ) in Spice

Not browsing as part of any series.

Commit Message

Yuri Benditovich Aug. 12, 2019, 9:57 a.m.
Add implementation of emulated device to build.
Now it is possible to create emulated CD devices.

Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
---
 src/meson.build | 7 +++++++
 1 file changed, 7 insertions(+)

Patch hide | download patch | download mbox

diff --git a/src/meson.build b/src/meson.build
index fe19c16..3837a9d 100644
--- a/src/meson.build
+++ b/src/meson.build
@@ -124,6 +124,13 @@  spice_client_glib_sources = [
   'usb-backend.c',
   'usb-emulation.h',
   'usb-backend.h',
+  'usb-device-cd.c',
+  'usb-device-cd.h',
+  'cd-scsi.c',
+  'cd-scsi.h',
+  'cd-scsi-dev-params.h',
+  'cd-usb-bulk-msd.c',
+  'cd-usb-bulk-msd.h',
   'vmcstream.c',
   'vmcstream.h',
 ]

Comments

> 
> Add implementation of emulated device to build.
> Now it is possible to create emulated CD devices.
> 
> Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>

Would be better to compile only if needed, like

https://gitlab.freedesktop.org/fziglio/spice-gtk/commit/f74443390902335a0233bb32e1d94507e5b9f5f4

?

> ---
>  src/meson.build | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/src/meson.build b/src/meson.build
> index fe19c16..3837a9d 100644
> --- a/src/meson.build
> +++ b/src/meson.build
> @@ -124,6 +124,13 @@ spice_client_glib_sources = [
>    'usb-backend.c',
>    'usb-emulation.h',
>    'usb-backend.h',
> +  'usb-device-cd.c',
> +  'usb-device-cd.h',
> +  'cd-scsi.c',
> +  'cd-scsi.h',
> +  'cd-scsi-dev-params.h',
> +  'cd-usb-bulk-msd.c',
> +  'cd-usb-bulk-msd.h',
>    'vmcstream.c',
>    'vmcstream.h',
>  ]

Frediano
On Tue, Aug 13, 2019 at 2:29 PM Frediano Ziglio <fziglio@redhat.com> wrote:
>
> >
> > Add implementation of emulated device to build.
> > Now it is possible to create emulated CD devices.
> >
> > Signed-off-by: Yuri Benditovich <yuri.benditovich@daynix.com>
>
> Would be better to compile only if needed, like
>
> https://gitlab.freedesktop.org/fziglio/spice-gtk/commit/f74443390902335a0233bb32e1d94507e5b9f5f4
>
> ?
>

No problem...

> > ---
> >  src/meson.build | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/src/meson.build b/src/meson.build
> > index fe19c16..3837a9d 100644
> > --- a/src/meson.build
> > +++ b/src/meson.build
> > @@ -124,6 +124,13 @@ spice_client_glib_sources = [
> >    'usb-backend.c',
> >    'usb-emulation.h',
> >    'usb-backend.h',
> > +  'usb-device-cd.c',
> > +  'usb-device-cd.h',
> > +  'cd-scsi.c',
> > +  'cd-scsi.h',
> > +  'cd-scsi-dev-params.h',
> > +  'cd-usb-bulk-msd.c',
> > +  'cd-usb-bulk-msd.h',
> >    'vmcstream.c',
> >    'vmcstream.h',
> >  ]
>
> Frediano