[spice-server,3/3] valgrind/spice.supp: add missing ...

Submitted by Uri Lublin on Aug. 11, 2019, 11:47 a.m.

Details

Message ID 20190811114723.22360-3-uril@redhat.com
State Accepted
Headers show
Series "Series without cover letter" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Uri Lublin Aug. 11, 2019, 11:47 a.m.
There may to be another function (cache_alt_names) between
  gnutls_x509_ext_import_subject_alt_names and
  gnutls_x509_crt_import

cache_alt_names is a static function in gnutls/lib/x509/x509.c
used only in gnutls_x509_crt_import and may be inlined by
the compiler.

Signed-off-by: Uri Lublin <uril@redhat.com>
---
 server/tests/valgrind/spice.supp | 1 +
 1 file changed, 1 insertion(+)

Patch hide | download patch | download mbox

diff --git a/server/tests/valgrind/spice.supp b/server/tests/valgrind/spice.supp
index aa64b61bc..284833a72 100644
--- a/server/tests/valgrind/spice.supp
+++ b/server/tests/valgrind/spice.supp
@@ -42,6 +42,7 @@ 
 	Memcheck:Cond
 	...
 	fun:gnutls_x509_ext_import_subject_alt_names
+	...
 	fun:gnutls_x509_crt_import
 	fun:gnutls_x509_trust_list_iter_get_ca
 }

Comments

> 
> There may to be another function (cache_alt_names) between
>   gnutls_x509_ext_import_subject_alt_names and
>   gnutls_x509_crt_import
> 
> cache_alt_names is a static function in gnutls/lib/x509/x509.c
> used only in gnutls_x509_crt_import and may be inlined by
> the compiler.
> 
> Signed-off-by: Uri Lublin <uril@redhat.com>

Acked.

If you have the exact environment where this happened worth adding
it in the commit message.

> ---
>  server/tests/valgrind/spice.supp | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/server/tests/valgrind/spice.supp
> b/server/tests/valgrind/spice.supp
> index aa64b61bc..284833a72 100644
> --- a/server/tests/valgrind/spice.supp
> +++ b/server/tests/valgrind/spice.supp
> @@ -42,6 +42,7 @@
>  	Memcheck:Cond
>  	...
>  	fun:gnutls_x509_ext_import_subject_alt_names
> +	...
>  	fun:gnutls_x509_crt_import
>  	fun:gnutls_x509_trust_list_iter_get_ca
>  }

Frediano
On 8/11/19 2:57 PM, Frediano Ziglio wrote:
>>
>> There may to be another function (cache_alt_names) between
>>    gnutls_x509_ext_import_subject_alt_names and
>>    gnutls_x509_crt_import
>>
>> cache_alt_names is a static function in gnutls/lib/x509/x509.c
>> used only in gnutls_x509_crt_import and may be inlined by
>> the compiler.
>>
>> Signed-off-by: Uri Lublin <uril@redhat.com>
> 
> Acked.
> 
> If you have the exact environment where this happened worth adding
> it in the commit message.

After a little investigation,
Turns out the "problem" was a gnutls-debuginfo package that
was installed on my machine.
With gnutls-debuginfo, valgrind fails for test-listen.
Removing it makes valgrind pass test-listen.

I'll add this information to the commit log.

Thanks,
     Uri.

> 
>> ---
>>   server/tests/valgrind/spice.supp | 1 +
>>   1 file changed, 1 insertion(+)
>>
>> diff --git a/server/tests/valgrind/spice.supp
>> b/server/tests/valgrind/spice.supp
>> index aa64b61bc..284833a72 100644
>> --- a/server/tests/valgrind/spice.supp
>> +++ b/server/tests/valgrind/spice.supp
>> @@ -42,6 +42,7 @@
>>   	Memcheck:Cond
>>   	...
>>   	fun:gnutls_x509_ext_import_subject_alt_names
>> +	...
>>   	fun:gnutls_x509_crt_import
>>   	fun:gnutls_x509_trust_list_iter_get_ca
>>   }
> 
> Frediano
>