drm/imx: Drop unused imx-ipuv3-crtc.o build

Submitted by Guido Günther on Aug. 2, 2019, 10:55 a.m.

Details

Message ID e5484fa33bffec220fd0590b502a962da17c9c72.1564743270.git.agx@sigxcpu.org
State Accepted
Commit c23ef285fc67f5fd2d7faac4d14d8b8c5a2b23ab
Headers show
Series "drm/imx: Drop unused imx-ipuv3-crtc.o build" ( rev: 1 ) in DRI devel

Not browsing as part of any series.

Commit Message

Guido Günther Aug. 2, 2019, 10:55 a.m.
Since

commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")

imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an
extra entry with a non existing config value (CONFIG_DRM_IMX_IPUV3).

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
 drivers/gpu/drm/imx/Makefile | 1 -
 1 file changed, 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/imx/Makefile b/drivers/gpu/drm/imx/Makefile
index ab6c83caceb7..21cdcc2faabc 100644
--- a/drivers/gpu/drm/imx/Makefile
+++ b/drivers/gpu/drm/imx/Makefile
@@ -8,5 +8,4 @@  obj-$(CONFIG_DRM_IMX_PARALLEL_DISPLAY) += parallel-display.o
 obj-$(CONFIG_DRM_IMX_TVE) += imx-tve.o
 obj-$(CONFIG_DRM_IMX_LDB) += imx-ldb.o
 
-obj-$(CONFIG_DRM_IMX_IPUV3)	+= imx-ipuv3-crtc.o
 obj-$(CONFIG_DRM_IMX_HDMI) += dw_hdmi-imx.o

Comments

Hi Guido,

Good catch!

On Fri, Aug 2, 2019 at 7:55 AM Guido Günther <agx@sigxcpu.org> wrote:
>
> Since
>
> commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
>
> imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an

Actually, it is ipuv3-crtc.o that is built via imxdrm-objs, not
imx-ipuv3-crtc.o.

Apart from that:

Reviewed-by: Fabio Estevam <festevam@gmail.com>
Hi Guido, Fabio,

On Fri, 2019-08-02 at 08:03 -0300, Fabio Estevam wrote:
> Hi Guido,
> 
> Good catch!
> 
> On Fri, Aug 2, 2019 at 7:55 AM Guido Günther <agx@sigxcpu.org> wrote:
> > 
> > Since
> > 
> > commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
> > 
> > imx-ipuv3-crtc.o is built via imxdrm-objs. So there's no need to keep an
> 
> Actually, it is ipuv3-crtc.o that is built via imxdrm-objs, not
> imx-ipuv3-crtc.o.
> 
> Apart from that:
> 
> Reviewed-by: Fabio Estevam <festevam@gmail.com>

Thank you, applied to imx-drm/next with Fabio's R-b, and added Fixes:
tag, and the commit message changed as follows:

    drm/imx: Drop unused imx-ipuv3-crtc.o build
    
    Since
    
    commit 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
    
    the former contents of imx-ipuv3-crtc.o are built via imxdrm-objs. So
    there's no need to keep an extra entry with a non existing config value
    (CONFIG_DRM_IMX_IPUV3).
    
    Fixes: 3d1df96ad468 ("drm/imx: merge imx-drm-core and ipuv3-crtc in one module")
    Signed-off-by: Guido Günther <agx@sigxcpu.org>
    Reviewed-by: Fabio Estevam <festevam@gmail.com>
    Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>

no action necessary if you agree, otherwise just send a v2 and I'll
replace it.

regards
Philipp