[1/3] drm/i915/oa: add content to Makefile

Submitted by Jani Nikula on July 30, 2019, 11:34 a.m.

Details

Message ID 20190730113432.22146-1-jani.nikula@intel.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Intel GFX

Not browsing as part of any series.

Commit Message

Jani Nikula July 30, 2019, 11:34 a.m.
Apparently the empty Makefile has caused some confusion. Add the
subdir-cc-flags-y as in 7fcc7ca549d4 ("drm/i915: add header search path
to subdir Makefiles") which should be useful.

The generated headers still aren't self-contained, so can't add that.

References: http://marc.info/?i=80bf2204-558a-6d3f-c493-bf17b891fc8a@infradead.org
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>

---

This should fix the kernel header generation:
https://github.com/rib/gputop/pull/203
---
 drivers/gpu/drm/i915/oa/Makefile | 4 ++++
 1 file changed, 4 insertions(+)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/oa/Makefile b/drivers/gpu/drm/i915/oa/Makefile
index e69de29bb2d1..256bfde4a287 100644
--- a/drivers/gpu/drm/i915/oa/Makefile
+++ b/drivers/gpu/drm/i915/oa/Makefile
@@ -0,0 +1,4 @@ 
+# SPDX-License-Identifier: MIT
+
+# For building individual subdir files on the command line
+subdir-ccflags-y += -I$(srctree)/$(src)/..

Comments

On Tue, 30 Jul 2019 13:34:30 +0200, Jani Nikula <jani.nikula@intel.com>  
wrote:

> Apparently the empty Makefile has caused some confusion. Add the
> subdir-cc-flags-y as in 7fcc7ca549d4 ("drm/i915: add header search path
> to subdir Makefiles") which should be useful.
>
> The generated headers still aren't self-contained, so can't add that.
>
> References:  
> http://marc.info/?i=80bf2204-558a-6d3f-c493-bf17b891fc8a@infradead.org
> Cc: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>

Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>
On Tue, 30 Jul 2019, Michal Wajdeczko <michal.wajdeczko@intel.com> wrote:
> On Tue, 30 Jul 2019 13:34:30 +0200, Jani Nikula <jani.nikula@intel.com>  
> wrote:
>
>> Apparently the empty Makefile has caused some confusion. Add the
>> subdir-cc-flags-y as in 7fcc7ca549d4 ("drm/i915: add header search path
>> to subdir Makefiles") which should be useful.
>>
>> The generated headers still aren't self-contained, so can't add that.
>>
>> References:  
>> http://marc.info/?i=80bf2204-558a-6d3f-c493-bf17b891fc8a@infradead.org
>> Cc: Chris Wilson <chris@chris-wilson.co.uk>
>> Cc: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>> Cc: Michal Wajdeczko <michal.wajdeczko@intel.com>
>> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
>>
>
> Reviewed-by: Michal Wajdeczko <michal.wajdeczko@intel.com>

Thanks, pushed the one patch to dinq. May I trouble you for review on
patches 2 and 3 as well please?

BR,
Jani.