[spice-server,2/3] glz-encoder: Remove useless __packed__ attribute

Submitted by Frediano Ziglio on July 22, 2019, 11:08 a.m.

Details

Message ID 20190722110841.31711-2-fziglio@redhat.com
State Accepted
Commit b22ce8b04298cc9f224a5c5ef7a462c3667224d7
Headers show
Series "Series without cover letter" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio July 22, 2019, 11:08 a.m.
These structure contain only bytes, no need for this attribute.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 server/glz-encoder.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

Patch hide | download patch | download mbox

diff --git a/server/glz-encoder.c b/server/glz-encoder.c
index 341294035..ee9d95ae9 100644
--- a/server/glz-encoder.c
+++ b/server/glz-encoder.c
@@ -168,18 +168,18 @@  void glz_encoder_destroy(GlzEncoderContext *opaque_encoder)
 
 typedef uint8_t BYTE;
 
-typedef struct __attribute__ ((__packed__)) one_byte_pixel_t {
+typedef struct one_byte_pixel_t {
     BYTE a;
 } one_byte_pixel_t;
 
-typedef struct __attribute__ ((__packed__)) rgb32_pixel_t {
+typedef struct rgb32_pixel_t {
     BYTE b;
     BYTE g;
     BYTE r;
     BYTE pad;
 } rgb32_pixel_t;
 
-typedef struct __attribute__ ((__packed__)) rgb24_pixel_t {
+typedef struct rgb24_pixel_t {
     BYTE b;
     BYTE g;
     BYTE r;

Comments

ping

> 
> These structure contain only bytes, no need for this attribute.
> 
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
> ---
>  server/glz-encoder.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/server/glz-encoder.c b/server/glz-encoder.c
> index 341294035..ee9d95ae9 100644
> --- a/server/glz-encoder.c
> +++ b/server/glz-encoder.c
> @@ -168,18 +168,18 @@ void glz_encoder_destroy(GlzEncoderContext
> *opaque_encoder)
>  
>  typedef uint8_t BYTE;
>  
> -typedef struct __attribute__ ((__packed__)) one_byte_pixel_t {
> +typedef struct one_byte_pixel_t {
>      BYTE a;
>  } one_byte_pixel_t;
>  
> -typedef struct __attribute__ ((__packed__)) rgb32_pixel_t {
> +typedef struct rgb32_pixel_t {
>      BYTE b;
>      BYTE g;
>      BYTE r;
>      BYTE pad;
>  } rgb32_pixel_t;
>  
> -typedef struct __attribute__ ((__packed__)) rgb24_pixel_t {
> +typedef struct rgb24_pixel_t {
>      BYTE b;
>      BYTE g;
>      BYTE r;
> --
> 2.20.1
> 
>