drm/amdgpu: Remove undefined amdgpu_device_parse_faked_did

Submitted by Li, Sun peng (Leo) on July 18, 2019, 4:17 p.m.

Details

Message ID 20190718161756.22875-1-sunpeng.li@amd.com
State New
Headers show
Series "drm/amdgpu: Remove undefined amdgpu_device_parse_faked_did" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Li, Sun peng (Leo) July 18, 2019, 4:17 p.m.
From: Leo Li <sunpeng.li@amd.com>

This forward declare was added for no apparent reason. Remove it to
resolve this warning:

drivers/gpu/drm//amd/amdgpu/amdgpu_device.c:131:13: warning: ‘amdgpu_device_parse_faked_did’ declared ‘static’ but never defined [-Wunused-function]
 static void amdgpu_device_parse_faked_did(struct amdgpu_device *adev);

Cc: Michel Dänzer <michel@daenzer.net>
Signed-off-by: Leo Li <sunpeng.li@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
 1 file changed, 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
index 76106ad8ac84..4425ff06ecc4 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
@@ -128,7 +128,6 @@  static DEVICE_ATTR(pcie_replay_count, S_IRUGO,
 		amdgpu_device_get_pcie_replay_count, NULL);
 
 static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev);
-static void amdgpu_device_parse_faked_did(struct amdgpu_device *adev);
 
 /**
  * amdgpu_device_is_px - Is the device is a dGPU with HG/PX power control

Comments

On 2019-07-18 6:17 p.m., sunpeng.li@amd.com wrote:
> From: Leo Li <sunpeng.li@amd.com>
> 
> This forward declare was added for no apparent reason. Remove it to
> resolve this warning:
> 
> drivers/gpu/drm//amd/amdgpu/amdgpu_device.c:131:13: warning: ‘amdgpu_device_parse_faked_did’ declared ‘static’ but never defined [-Wunused-function]
>  static void amdgpu_device_parse_faked_did(struct amdgpu_device *adev);
> 
> Cc: Michel Dänzer <michel@daenzer.net>
> Signed-off-by: Leo Li <sunpeng.li@amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index 76106ad8ac84..4425ff06ecc4 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -128,7 +128,6 @@ static DEVICE_ATTR(pcie_replay_count, S_IRUGO,
>  		amdgpu_device_get_pcie_replay_count, NULL);
>  
>  static void amdgpu_device_get_pcie_info(struct amdgpu_device *adev);
> -static void amdgpu_device_parse_faked_did(struct amdgpu_device *adev);
>  
>  /**
>   * amdgpu_device_is_px - Is the device is a dGPU with HG/PX power control
> 

Thanks Leo.

Reviewed-by: Michel Dänzer <michel.daenzer@amd.com>