[v2,2/3] radv/gfx10: do not emit VGT_GS_MODE

Submitted by Samuel Pitoiset on July 18, 2019, 8:14 a.m.

Details

Message ID 20190718081409.4370-2-samuel.pitoiset@gmail.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Samuel Pitoiset July 18, 2019, 8:14 a.m.
Unnecessary.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
---
 src/amd/vulkan/radv_pipeline.c | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index bcb7ccc803d..b11d79f4811 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -3274,6 +3274,9 @@  radv_pipeline_generate_vgt_gs_mode(struct radeon_cmdbuf *ctx_cs,
 	unsigned vgt_primitiveid_en = 0;
 	uint32_t vgt_gs_mode = 0;
 
+	if (radv_pipeline_has_ngg(pipeline))
+		return;
+
 	if (radv_pipeline_has_gs(pipeline)) {
 		const struct radv_shader_variant *gs =
 			pipeline->shaders[MESA_SHADER_GEOMETRY];

Comments

We might want to merge this into patch 1, as we now emit the
R_028A84_VGT_PRIMITIVEID_EN twice after only patch 1.

Either way r-b for the series

On Thu, Jul 18, 2019 at 10:14 AM Samuel Pitoiset
<samuel.pitoiset@gmail.com> wrote:
>
> Unnecessary.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
> ---
>  src/amd/vulkan/radv_pipeline.c | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
> index bcb7ccc803d..b11d79f4811 100644
> --- a/src/amd/vulkan/radv_pipeline.c
> +++ b/src/amd/vulkan/radv_pipeline.c
> @@ -3274,6 +3274,9 @@ radv_pipeline_generate_vgt_gs_mode(struct radeon_cmdbuf *ctx_cs,
>         unsigned vgt_primitiveid_en = 0;
>         uint32_t vgt_gs_mode = 0;
>
> +       if (radv_pipeline_has_ngg(pipeline))
> +               return;
> +
>         if (radv_pipeline_has_gs(pipeline)) {
>                 const struct radv_shader_variant *gs =
>                         pipeline->shaders[MESA_SHADER_GEOMETRY];
> --
> 2.22.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev