[spice-server,3/3] ci: Add some Valgrind suppressions for Fedora 30

Submitted by Frediano Ziglio on July 18, 2019, 7:32 a.m.

Details

Message ID 20190718073225.13190-4-fziglio@redhat.com
State Accepted
Headers show
Series "Update Valgrind suppression files" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio July 18, 2019, 7:32 a.m.
Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 server/tests/valgrind/spice.supp | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

Patch hide | download patch | download mbox

diff --git a/server/tests/valgrind/spice.supp b/server/tests/valgrind/spice.supp
index 1bfe81006..dd3663c68 100644
--- a/server/tests/valgrind/spice.supp
+++ b/server/tests/valgrind/spice.supp
@@ -36,3 +36,28 @@ 
 	...
 	fun:p11_kit_modules_load
 }
+
+{
+	gnutls_x509_ext_import_subject_alt_names
+	Memcheck:Cond
+	...
+	fun:gnutls_x509_ext_import_subject_alt_names
+	fun:gnutls_x509_crt_import
+	fun:gnutls_x509_trust_list_iter_get_ca
+	...
+	fun:g_initable_new_valist
+	fun:g_initable_new
+	...
+}
+
+{
+	glib_g_socket_client_class_init
+	Memcheck:Leak
+	fun:calloc
+	...
+	fun:type_class_init_Wm
+	...
+	fun:g_socket_client_class_init
+	...
+	fun:type_class_init_Wm
+}

Comments

On 7/18/19 10:32 AM, Frediano Ziglio wrote:
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

Hi Frediano,

I've been playing with it too.
Had similar rules but different.

Your version works for me.
Some minor comments below.

> ---
>   server/tests/valgrind/spice.supp | 25 +++++++++++++++++++++++++
>   1 file changed, 25 insertions(+)
> 
> diff --git a/server/tests/valgrind/spice.supp b/server/tests/valgrind/spice.supp
> index 1bfe81006..dd3663c68 100644
> --- a/server/tests/valgrind/spice.supp
> +++ b/server/tests/valgrind/spice.supp
> @@ -36,3 +36,28 @@
>   	...
>   	fun:p11_kit_modules_load
>   }
> +
> +{
> +	gnutls_x509_ext_import_subject_alt_names
> +	Memcheck:Cond
> +	...
> +	fun:gnutls_x509_ext_import_subject_alt_names
> +	fun:gnutls_x509_crt_import
> +	fun:gnutls_x509_trust_list_iter_get_ca
> +	...
> +	fun:g_initable_new_valist
> +	fun:g_initable_new
> +	...

possibly you can remove the last 4 lines (not important)

> +}
> +
> +{
> +	glib_g_socket_client_class_init

Are all glib sockets leaking when initialized ?

> +	Memcheck:Leak
> +	fun:calloc
> +	...
> +	fun:type_class_init_Wm
> +	...
> +	fun:g_socket_client_class_init
> +	...
> +	fun:type_class_init_Wm

You can probably remove the type_class_init_Wm and ...

Uri.
> 
> On 7/18/19 10:32 AM, Frediano Ziglio wrote:
> > Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
> 
> Hi Frediano,
> 
> I've been playing with it too.
> Had similar rules but different.
> 
> Your version works for me.
> Some minor comments below.
> 
> > ---
> >   server/tests/valgrind/spice.supp | 25 +++++++++++++++++++++++++
> >   1 file changed, 25 insertions(+)
> > 
> > diff --git a/server/tests/valgrind/spice.supp
> > b/server/tests/valgrind/spice.supp
> > index 1bfe81006..dd3663c68 100644
> > --- a/server/tests/valgrind/spice.supp
> > +++ b/server/tests/valgrind/spice.supp
> > @@ -36,3 +36,28 @@
> >   	...
> >   	fun:p11_kit_modules_load
> >   }
> > +
> > +{
> > +	gnutls_x509_ext_import_subject_alt_names
> > +	Memcheck:Cond
> > +	...
> > +	fun:gnutls_x509_ext_import_subject_alt_names
> > +	fun:gnutls_x509_crt_import
> > +	fun:gnutls_x509_trust_list_iter_get_ca
> > +	...
> > +	fun:g_initable_new_valist
> > +	fun:g_initable_new
> > +	...
> 
> possibly you can remove the last 4 lines (not important)
> 

I'll try (with CI) to remove these lines (and below), if they work I'll remove
from the patch.

> > +}
> > +
> > +{
> > +	glib_g_socket_client_class_init
> 
> Are all glib sockets leaking when initialized ?
> 

Many. They perform single registration or initialization which
are never unregistered/uninitialized. Not only sockets.

> > +	Memcheck:Leak
> > +	fun:calloc
> > +	...
> > +	fun:type_class_init_Wm
> > +	...
> > +	fun:g_socket_client_class_init
> > +	...
> > +	fun:type_class_init_Wm
> 
> You can probably remove the type_class_init_Wm and ...
> 
> Uri.
> 

Frediano