[spice-server,v3] ci: Workaround an issue with GLib on Fedora 30

Submitted by Frediano Ziglio on July 17, 2019, 12:06 p.m.

Details

Message ID 20190717120652.11876-1-fziglio@redhat.com
State Accepted
Commit 89edf80821acaaf1a9287fdb682faa12e680de4f
Headers show
Series "ci: Workaround an issue with GLib on Fedora 30" ( rev: 3 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio July 17, 2019, 12:06 p.m.
This remove this error running test-listen test on a Fedora 30 docker
image:

(/builds/spice/spice/build/server/tests/test-listen:2233): GLib-GIO-CRITICAL **: 15:29:03.123: g_file_new_for_path: assertion 'path != NULL' failed

This error is due to some missing configuration on the image.
On a fully installed Desktop/Server machine these configuration
are usually in place so you won't note the issue but on recent
docker images these configuration are missing.

Running the dconf command add required configuration.

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 .gitlab-ci.yml | 7 +++++++
 1 file changed, 7 insertions(+)

Changes since v2:
- more comments

Patch hide | download patch | download mbox

diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
index b303d4656..316a860dd 100644
--- a/.gitlab-ci.yml
+++ b/.gitlab-ci.yml
@@ -8,9 +8,16 @@  before_script:
     glib2-devel celt051-devel pixman-devel alsa-lib-devel openssl-devel libjpeg-turbo-devel
     libcacard-devel cyrus-sasl-devel lz4-devel opus-devel
     gstreamer1-devel gstreamer1-plugins-base-devel
+    dconf
     -y
   - git clone ${CI_REPOSITORY_URL/spice.git/spice-protocol.git}
   - (cd spice-protocol && ./autogen.sh --prefix=/usr && make install)
+  # This is a workaround for Fedora docker image, this will add some
+  # missing configuration
+  # '/org/gnome/system/location/enabled' is just the first key path
+  # I found, nothing special in it
+  # TODO remove when the image will fix this issue
+  - dconf reset /org/gnome/system/location/enabled || true
 
 makecheck:
   script:

Comments

On 7/17/19 3:06 PM, Frediano Ziglio wrote:
> This remove this error running test-listen test on a Fedora 30 docker
> image:
> 
> (/builds/spice/spice/build/server/tests/test-listen:2233): GLib-GIO-CRITICAL **: 15:29:03.123: g_file_new_for_path: assertion 'path != NULL' failed
> 
> This error is due to some missing configuration on the image.
> On a fully installed Desktop/Server machine these configuration
> are usually in place so you won't note the issue but on recent
> docker images these configuration are missing.
> 
> Running the dconf command add required configuration.

This is indeed weird. But it works.

Thanks for adding the comment you added below.

> 
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
Ack.

Uri.

> ---
>   .gitlab-ci.yml | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> Changes since v2:
> - more comments
> 
> diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml
> index b303d4656..316a860dd 100644
> --- a/.gitlab-ci.yml
> +++ b/.gitlab-ci.yml
> @@ -8,9 +8,16 @@ before_script:
>       glib2-devel celt051-devel pixman-devel alsa-lib-devel openssl-devel libjpeg-turbo-devel
>       libcacard-devel cyrus-sasl-devel lz4-devel opus-devel
>       gstreamer1-devel gstreamer1-plugins-base-devel
> +    dconf
>       -y
>     - git clone ${CI_REPOSITORY_URL/spice.git/spice-protocol.git}
>     - (cd spice-protocol && ./autogen.sh --prefix=/usr && make install)
> +  # This is a workaround for Fedora docker image, this will add some
> +  # missing configuration
> +  # '/org/gnome/system/location/enabled' is just the first key path
> +  # I found, nothing special in it
> +  # TODO remove when the image will fix this issue
> +  - dconf reset /org/gnome/system/location/enabled || true
>   
>   makecheck:
>     script:
>