drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface

Submitted by StDenis, Tom on July 16, 2019, 11:24 a.m.

Details

Message ID 20190716112434.29017-1-tom.stdenis@amd.com
State Accepted
Commit 88891430a2c06b6be9b1ed08c095befb17fb4cb2
Headers show
Series "drm/amd/amdgpu: Fix offset for vmid selection in debugfs interface" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

StDenis, Tom July 16, 2019, 11:24 a.m.
The register debugfs interface was using the wrong bitmask for vmid
selection for GFX_CNTL.

Signed-off-by: Tom St Denis <tom.stdenis@amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
index 87b32873046f..59849ed9797d 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
@@ -132,7 +132,7 @@  static int  amdgpu_debugfs_process_reg_op(bool read, struct file *f,
 		me = (*pos & GENMASK_ULL(33, 24)) >> 24;
 		pipe = (*pos & GENMASK_ULL(43, 34)) >> 34;
 		queue = (*pos & GENMASK_ULL(53, 44)) >> 44;
-		vmid = (*pos & GENMASK_ULL(48, 45)) >> 54;
+		vmid = (*pos & GENMASK_ULL(58, 54)) >> 54;
 
 		use_ring = 1;
 	} else {

Comments

Am 16.07.19 um 13:24 schrieb StDenis, Tom:
> The register debugfs interface was using the wrong bitmask for vmid
> selection for GFX_CNTL.
>
> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>

Acked-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> index 87b32873046f..59849ed9797d 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c
> @@ -132,7 +132,7 @@ static int  amdgpu_debugfs_process_reg_op(bool read, struct file *f,
>   		me = (*pos & GENMASK_ULL(33, 24)) >> 24;
>   		pipe = (*pos & GENMASK_ULL(43, 34)) >> 34;
>   		queue = (*pos & GENMASK_ULL(53, 44)) >> 44;
> -		vmid = (*pos & GENMASK_ULL(48, 45)) >> 54;
> +		vmid = (*pos & GENMASK_ULL(58, 54)) >> 54;
>   
>   		use_ring = 1;
>   	} else {
Thanks.


Alex can I grab an R-b please?


Cheers,

Tom

On 2019-07-16 7:30 a.m., Christian König wrote:
> Am 16.07.19 um 13:24 schrieb StDenis, Tom:

>> The register debugfs interface was using the wrong bitmask for vmid

>> selection for GFX_CNTL.

>>

>> Signed-off-by: Tom St Denis <tom.stdenis@amd.com>

>

> Acked-by: Christian König <christian.koenig@amd.com>

>

>> ---

>>   drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c | 2 +-

>>   1 file changed, 1 insertion(+), 1 deletion(-)

>>

>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c 

>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c

>> index 87b32873046f..59849ed9797d 100644

>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c

>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c

>> @@ -132,7 +132,7 @@ static int amdgpu_debugfs_process_reg_op(bool 

>> read, struct file *f,

>>           me = (*pos & GENMASK_ULL(33, 24)) >> 24;

>>           pipe = (*pos & GENMASK_ULL(43, 34)) >> 34;

>>           queue = (*pos & GENMASK_ULL(53, 44)) >> 44;

>> -        vmid = (*pos & GENMASK_ULL(48, 45)) >> 54;

>> +        vmid = (*pos & GENMASK_ULL(58, 54)) >> 54;

>>             use_ring = 1;

>>       } else {

>