[1/2] drm/amd/powerplay: maintain SMU FW backward compatibility

Submitted by Feng, Kenneth on July 16, 2019, 8:53 a.m.

Details

Message ID MN2PR12MB3598699DFE48E022FBAD11ED8ECE0@MN2PR12MB3598.namprd12.prod.outlook.com
State New
Headers show
Series "Series without cover letter" ( rev: 3 2 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Feng, Kenneth July 16, 2019, 8:53 a.m.
Reviewed-by: Kenneth Feng <kenneth.feng@amd.com>




-----Original Message-----
From: amd-gfx [mailto:amd-gfx-bounces@lists.freedesktop.org] On Behalf Of Evan Quan

Sent: Tuesday, July 16, 2019 4:51 PM
To: amd-gfx@lists.freedesktop.org
Cc: Deucher, Alexander <Alexander.Deucher@amd.com>; Quan, Evan <Evan.Quan@amd.com>
Subject: [PATCH 1/2] drm/amd/powerplay: maintain SMU FW backward compatibility

[CAUTION: External Email]

Do not halt driver loading on if_version mismatch. As our driver and FWs are backward compatible.

Change-Id: I01271202d08a62e775efabfb66310f6cc742b9dd
Signed-off-by: Evan Quan <evan.quan@amd.com>

---
 drivers/gpu/drm/amd/powerplay/smu_v11_0.c | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

--
2.21.0

_______________________________________________
amd-gfx mailing list
amd-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/amd-gfx

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
index bc4f8de629b5..12c6482d37f4 100644
--- a/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
+++ b/drivers/gpu/drm/amd/powerplay/smu_v11_0.c
@@ -262,14 +262,20 @@  static int smu_v11_0_check_fw_version(struct smu_context *smu)
        smu_minor = (smu_version >> 8) & 0xff;
        smu_debug = (smu_version >> 0) & 0xff;

-
+       /*
+        * 1. if_version mismatch is not critical as our fw is designed
+        * to be backward compatible.
+        * 2. New fw usually brings some optimizations. But that's visible
+        * only on the paired driver.
+        * Considering above, we just leave user a warning message instead
+        * of halt driver loading.
+        */
        if (if_version != smu->smc_if_version) {
                pr_info("smu driver if version = 0x%08x, smu fw if version = 0x%08x, "
                        "smu fw version = 0x%08x (%d.%d.%d)\n",
                        smu->smc_if_version, if_version,
                        smu_version, smu_major, smu_minor, smu_debug);
-               pr_err("SMU driver if version not matched\n");
-               ret = -EINVAL;
+               pr_warn("SMU driver if version not matched\n");
        }

        return ret;