[spice-server,v2,2/3] dcc-send: remove unused variable 'image'

Submitted by Uri Lublin on July 10, 2019, 5:44 p.m.

Details

Message ID 20190710174435.15833-3-uril@redhat.com
State Accepted
Commit 636f9c25a60d6f796aacb9ab248beaf10cf36f58
Headers show
Series "dcc-send: remove useless pipe_item assignment pipe_item" ( rev: 2 ) in Spice

Not browsing as part of any series.

Commit Message

Uri Lublin July 10, 2019, 5:44 p.m.
From: Frediano Ziglio <fziglio@redhat.com>

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 server/dcc-send.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/server/dcc-send.c b/server/dcc-send.c
index 565a79f33..e0f3b8183 100644
--- a/server/dcc-send.c
+++ b/server/dcc-send.c
@@ -725,7 +725,6 @@  static void red_pipe_replace_rendered_drawables_with_images(DisplayChannelClient
         RedPipeItem *pipe_item = l->data;
         Drawable *drawable;
         RedDrawablePipeItem *dpi;
-        RedImageItem *image;
 
         if (pipe_item->type != RED_PIPE_ITEM_TYPE_DRAW)
             continue;
@@ -745,13 +744,12 @@  static void red_pipe_replace_rendered_drawables_with_images(DisplayChannelClient
             continue;
         }
 
-        image = dcc_add_surface_area_image(dcc, drawable->red_drawable->surface_id,
-                                           &drawable->red_drawable->bbox, l, TRUE);
+        dcc_add_surface_area_image(dcc, drawable->red_drawable->surface_id,
+                                   &drawable->red_drawable->bbox, l, TRUE);
         resent_surface_ids[num_resent] = drawable->red_drawable->surface_id;
         resent_areas[num_resent] = drawable->red_drawable->bbox;
         num_resent++;
 
-        spice_assert(image);
         red_channel_client_pipe_remove_and_release_pos(RED_CHANNEL_CLIENT(dcc), l);
     }
 }

Comments

> 
> From: Frediano Ziglio <fziglio@redhat.com>
> 
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>

I supposed someone else should ack it

> ---
>  server/dcc-send.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/server/dcc-send.c b/server/dcc-send.c
> index 565a79f33..e0f3b8183 100644
> --- a/server/dcc-send.c
> +++ b/server/dcc-send.c
> @@ -725,7 +725,6 @@ static void
> red_pipe_replace_rendered_drawables_with_images(DisplayChannelClient
>          RedPipeItem *pipe_item = l->data;
>          Drawable *drawable;
>          RedDrawablePipeItem *dpi;
> -        RedImageItem *image;
>  
>          if (pipe_item->type != RED_PIPE_ITEM_TYPE_DRAW)
>              continue;
> @@ -745,13 +744,12 @@ static void
> red_pipe_replace_rendered_drawables_with_images(DisplayChannelClient
>              continue;
>          }
>  
> -        image = dcc_add_surface_area_image(dcc,
> drawable->red_drawable->surface_id,
> -                                           &drawable->red_drawable->bbox, l,
> TRUE);
> +        dcc_add_surface_area_image(dcc, drawable->red_drawable->surface_id,
> +                                   &drawable->red_drawable->bbox, l, TRUE);
>          resent_surface_ids[num_resent] = drawable->red_drawable->surface_id;
>          resent_areas[num_resent] = drawable->red_drawable->bbox;
>          num_resent++;
>  
> -        spice_assert(image);
>          red_channel_client_pipe_remove_and_release_pos(RED_CHANNEL_CLIENT(dcc),
>          l);
>      }
>  }

Frediano