[spice-server,v2] test-codecs-parsing: On bad codec string spice_server_set_video_codecs can fail

Submitted by Frediano Ziglio on July 7, 2019, 4:26 p.m.

Details

Message ID 20190707162624.12059-1-fziglio@redhat.com
State Accepted
Commit fdf104fe28aeefa8e0d01fb42f15ea5c6495cbd7
Headers show
Series "test-codecs-parsing: On bad codec string spice_server_set_video_codecs can fail" ( rev: 2 ) in Spice

Not browsing as part of any series.

Commit Message

Frediano Ziglio July 7, 2019, 4:26 p.m.
The 0 result means success however the function (correctly) could
report a failure if the string is incorrect.
This fixes the test after commit b4150de3cd0e56d4ce43a99ef5c3c5f5cbdfc4a3
("spice_server_set_video_codecs: fail when no codec can be installed").

Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
---
 server/tests/test-codecs-parsing.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Changes since v1:
- check always error setting codecs.

Patch hide | download patch | download mbox

diff --git a/server/tests/test-codecs-parsing.c b/server/tests/test-codecs-parsing.c
index 7998501c9..0037c058f 100644
--- a/server/tests/test-codecs-parsing.c
+++ b/server/tests/test-codecs-parsing.c
@@ -140,7 +140,7 @@  static void codecs_bad(void)
         g_test_expect_message(G_LOG_DOMAIN, test_cases[i].log_level, test_cases[i].error_message);
         if (test_cases[i].default_err_message)
             g_test_expect_message(G_LOG_DOMAIN, G_LOG_LEVEL_WARNING, "*Failed to set video codecs*");
-        g_assert_cmpint(spice_server_set_video_codecs(server, test_cases[i].codecs), ==, 0);
+        g_assert_cmpint(spice_server_set_video_codecs(server, test_cases[i].codecs), !=, 0);
         g_test_assert_expected_messages();
     }
 

Comments

Acked-by: Snir Sheriber <ssheribe@redhat.com


On 7/7/19 7:26 PM, Frediano Ziglio wrote:
> The 0 result means success however the function (correctly) could
> report a failure if the string is incorrect.
> This fixes the test after commit b4150de3cd0e56d4ce43a99ef5c3c5f5cbdfc4a3
> ("spice_server_set_video_codecs: fail when no codec can be installed").
>
> Signed-off-by: Frediano Ziglio <fziglio@redhat.com>
> ---
>   server/tests/test-codecs-parsing.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> Changes since v1:
> - check always error setting codecs.
>
> diff --git a/server/tests/test-codecs-parsing.c b/server/tests/test-codecs-parsing.c
> index 7998501c9..0037c058f 100644
> --- a/server/tests/test-codecs-parsing.c
> +++ b/server/tests/test-codecs-parsing.c
> @@ -140,7 +140,7 @@ static void codecs_bad(void)
>           g_test_expect_message(G_LOG_DOMAIN, test_cases[i].log_level, test_cases[i].error_message);
>           if (test_cases[i].default_err_message)
>               g_test_expect_message(G_LOG_DOMAIN, G_LOG_LEVEL_WARNING, "*Failed to set video codecs*");
> -        g_assert_cmpint(spice_server_set_video_codecs(server, test_cases[i].codecs), ==, 0);
> +        g_assert_cmpint(spice_server_set_video_codecs(server, test_cases[i].codecs), !=, 0);
>           g_test_assert_expected_messages();
>       }
>