[3/5] radv: remove set but unused aspect mask during depth layout transitions

Submitted by Samuel Pitoiset on July 2, 2019, 12:50 p.m.

Details

Message ID 20190702125028.11426-3-samuel.pitoiset@gmail.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Samuel Pitoiset July 2, 2019, 12:50 p.m.
The decompress/resummarize pass always use the depth aspect.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
---
 src/amd/vulkan/radv_cmd_buffer.c | 1 -
 1 file changed, 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index fc8184200fc..322e705621f 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -4895,7 +4895,6 @@  static void radv_handle_depth_image_transition(struct radv_cmd_buffer *cmd_buffe
 	} else if (radv_layout_is_htile_compressed(image, src_layout, src_queue_mask) &&
 	           !radv_layout_is_htile_compressed(image, dst_layout, dst_queue_mask)) {
 		VkImageSubresourceRange local_range = *range;
-		local_range.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT;
 		local_range.baseMipLevel = 0;
 		local_range.levelCount = 1;
 

Comments

I really like just always filling the struct completely. Provides a
better abstraction and less surprises.

On Tue, Jul 2, 2019 at 2:47 PM Samuel Pitoiset
<samuel.pitoiset@gmail.com> wrote:
>
> The decompress/resummarize pass always use the depth aspect.
>
> Signed-off-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
> ---
>  src/amd/vulkan/radv_cmd_buffer.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
> index fc8184200fc..322e705621f 100644
> --- a/src/amd/vulkan/radv_cmd_buffer.c
> +++ b/src/amd/vulkan/radv_cmd_buffer.c
> @@ -4895,7 +4895,6 @@ static void radv_handle_depth_image_transition(struct radv_cmd_buffer *cmd_buffe
>         } else if (radv_layout_is_htile_compressed(image, src_layout, src_queue_mask) &&
>                    !radv_layout_is_htile_compressed(image, dst_layout, dst_queue_mask)) {
>                 VkImageSubresourceRange local_range = *range;
> -               local_range.aspectMask = VK_IMAGE_ASPECT_DEPTH_BIT;
>                 local_range.baseMipLevel = 0;
>                 local_range.levelCount = 1;
>
> --
> 2.22.0
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev