drm/i915: use wildcard to ensure all headers stay self-contained

Submitted by Jani Nikula on June 27, 2019, 9:11 a.m.

Details

Message ID 20190627091111.14602-1-jani.nikula@intel.com
State New
Headers show
Series "drm/i915: use wildcard to ensure all headers stay self-contained" ( rev: 1 ) in Intel GFX

Not browsing as part of any series.

Commit Message

Jani Nikula June 27, 2019, 9:11 a.m.
Follow suit with the header tests in the subdirectories.

v2: no need to filter i915_oa_*.h as they were moved to oa/ subdir

Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/Makefile.header-test | 28 +----------------------
 1 file changed, 1 insertion(+), 27 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
index 2fd61869bdaa..cef34bf1e827 100644
--- a/drivers/gpu/drm/i915/Makefile.header-test
+++ b/drivers/gpu/drm/i915/Makefile.header-test
@@ -2,33 +2,7 @@ 
 # Copyright © 2019 Intel Corporation
 
 # Test the headers are compilable as standalone units
-header_test := \
-	i915_active_types.h \
-	i915_debugfs.h \
-	i915_drv.h \
-	i915_fixed.h \
-	i915_gem_gtt.h \
-	i915_globals.h \
-	i915_irq.h \
-	i915_params.h \
-	i915_priolist_types.h \
-	i915_pvinfo.h \
-	i915_reg.h \
-	i915_scheduler_types.h \
-	i915_utils.h \
-	i915_vgpu.h \
-	intel_csr.h \
-	intel_drv.h \
-	intel_guc_ct.h \
-	intel_guc_fwif.h \
-	intel_guc_reg.h \
-	intel_gvt.h \
-	intel_pm.h \
-	intel_runtime_pm.h \
-	intel_sideband.h \
-	intel_uc_fw.h \
-	intel_uncore.h \
-	intel_wakeref.h
+header_test := $(notdir $(wildcard $(src)/*.h))
 
 quiet_cmd_header_test = HDRTEST $@
       cmd_header_test = echo "\#include \"$(<F)\"" > $@

Comments

Quoting Jani Nikula (2019-06-27 10:11:11)
> Follow suit with the header tests in the subdirectories.
> 
> v2: no need to filter i915_oa_*.h as they were moved to oa/ subdir
> 
> Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk> # v1
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/Makefile.header-test | 28 +----------------------
>  1 file changed, 1 insertion(+), 27 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/Makefile.header-test b/drivers/gpu/drm/i915/Makefile.header-test
> index 2fd61869bdaa..cef34bf1e827 100644
> --- a/drivers/gpu/drm/i915/Makefile.header-test
> +++ b/drivers/gpu/drm/i915/Makefile.header-test
> @@ -2,33 +2,7 @@
>  # Copyright © 2019 Intel Corporation
>  
>  # Test the headers are compilable as standalone units
> -header_test := \
> -       i915_active_types.h \
> -       i915_debugfs.h \
> -       i915_drv.h \
> -       i915_fixed.h \
> -       i915_gem_gtt.h \
> -       i915_globals.h \
> -       i915_irq.h \
> -       i915_params.h \
> -       i915_priolist_types.h \
> -       i915_pvinfo.h \
> -       i915_reg.h \
> -       i915_scheduler_types.h \
> -       i915_utils.h \
> -       i915_vgpu.h \
> -       intel_csr.h \
> -       intel_drv.h \
> -       intel_guc_ct.h \
> -       intel_guc_fwif.h \
> -       intel_guc_reg.h \
> -       intel_gvt.h \
> -       intel_pm.h \
> -       intel_runtime_pm.h \
> -       intel_sideband.h \
> -       intel_uc_fw.h \
> -       intel_uncore.h \
> -       intel_wakeref.h
> +header_test := $(notdir $(wildcard $(src)/*.h))

No more subst to try and parse,
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris