[1/3] Revert "panfrost/midgard: Enable autovectorization"

Submitted by Tomeu Vizoso on June 20, 2019, 9:18 a.m.

Details

Message ID 20190620091821.35615-2-tomeu.vizoso@collabora.com
State New
Headers show
Series "Make CI green again" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Tomeu Vizoso June 20, 2019, 9:18 a.m.
This reverts commit 9402970751ca04c4d6edb3a0441a4063a975295c.
---
 src/gallium/drivers/panfrost/midgard/midgard_compile.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/gallium/drivers/panfrost/midgard/midgard_compile.c b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
index 1cc551b603c7..0c8032cc80bf 100644
--- a/src/gallium/drivers/panfrost/midgard/midgard_compile.c
+++ b/src/gallium/drivers/panfrost/midgard/midgard_compile.c
@@ -476,7 +476,8 @@  optimise_nir(nir_shader *nir)
                          nir_var_shader_out |
                          nir_var_function_temp);
 
-                NIR_PASS(progress, nir, nir_opt_vectorize);
+                /* TODO: Enable vectorize when merged upstream */
+                // NIR_PASS(progress, nir, nir_opt_vectorize);
         } while (progress);
 
         /* Must be run at the end to prevent creation of fsin/fcos ops */

Comments


On 6/20/19 3:28 PM, Alyssa Rosenzweig wrote:
> NAK. There's a patch for this I pushed to your repo which should fix
> these regressions (they were legitimate bugs that had nothing to do with
> autovectorization and would have cropped up anyhow).

You mean this commit?

https://gitlab.freedesktop.org/tomeu/mesa/commit/87b18087168718678bc818ca6869e031ddd90ca4

That one seems to introduce quite a few other regressions.

Thanks,

Tomeu