[libdrm,5/9] panfrost/midgard: Remove unnecessary variables

Submitted by Rohan Garg on June 12, 2019, 11:24 a.m.

Details

Message ID 20190612112439.7483-6-rohan.garg@collabora.com
State New
Headers show
Series "panfrost/midgard: Refactor pan_context" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Rohan Garg June 12, 2019, 11:24 a.m.
These are not required anymore since mali jobs are
now linked lists i.e. u_vertex_jobs and u_tiler_jobs
---
 src/gallium/drivers/panfrost/pan_context.c   | 5 -----
 src/gallium/drivers/panfrost/pan_context.h   | 2 --
 src/gallium/drivers/panfrost/pan_wallpaper.c | 1 -
 3 files changed, 8 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c
index d372f295979..66762a010f8 100644
--- a/src/gallium/drivers/panfrost/pan_context.c
+++ b/src/gallium/drivers/panfrost/pan_context.c
@@ -622,9 +622,6 @@  panfrost_vertex_tiler_job(struct panfrost_context *ctx, bool is_tiler)
                 if (ctx->draw_count) {
                         /* Previous vertex job points to this vertex job */
                         panfrost_link_job_pair(ctx->u_vertex_jobs[ctx->draw_count - 1], transfer.gpu);
-
-                        /* Last vertex job points to first tiler job */
-                        panfrost_link_job_pair(&job, ctx->tiler_jobs[0]);
                 } else {
                         /* Have the first vertex job depend on the set value job */
                         job.job_dependency_index_1 = ctx->u_set_value_job->job_index;
@@ -1264,11 +1261,9 @@  panfrost_queue_draw(struct panfrost_context *ctx)
 
         struct panfrost_transfer vertex = panfrost_vertex_tiler_job(ctx, false);
         ctx->u_vertex_jobs[ctx->vertex_job_count] = (struct mali_job_descriptor_header *) vertex.cpu;
-        ctx->vertex_jobs[ctx->vertex_job_count++] = vertex.gpu;
 
         struct panfrost_transfer tiler = panfrost_vertex_tiler_job(ctx, true);
         ctx->u_tiler_jobs[ctx->tiler_job_count] = (struct mali_job_descriptor_header *) tiler.cpu;
-        ctx->tiler_jobs[ctx->tiler_job_count++] = tiler.gpu;
 
         ctx->draw_count++;
 }
diff --git a/src/gallium/drivers/panfrost/pan_context.h b/src/gallium/drivers/panfrost/pan_context.h
index e3dc07059b5..27bb92b8330 100644
--- a/src/gallium/drivers/panfrost/pan_context.h
+++ b/src/gallium/drivers/panfrost/pan_context.h
@@ -156,8 +156,6 @@  struct panfrost_context {
         unsigned draw_count;
 
         mali_ptr set_value_job;
-        mali_ptr vertex_jobs[MAX_DRAW_CALLS];
-        mali_ptr tiler_jobs[MAX_DRAW_CALLS];
 
         struct mali_job_descriptor_header *u_set_value_job;
         struct mali_job_descriptor_header *u_vertex_jobs[MAX_DRAW_CALLS];
diff --git a/src/gallium/drivers/panfrost/pan_wallpaper.c b/src/gallium/drivers/panfrost/pan_wallpaper.c
index ac77ad089bc..963ab608ab7 100644
--- a/src/gallium/drivers/panfrost/pan_wallpaper.c
+++ b/src/gallium/drivers/panfrost/pan_wallpaper.c
@@ -250,7 +250,6 @@  panfrost_draw_wallpaper(struct pipe_context *pipe)
         struct panfrost_transfer tiler = panfrost_vertex_tiler_job(ctx, true, true);
         struct mali_job_descriptor_header *jd = (struct mali_job_descriptor_header *) tiler.cpu;
         ctx->u_tiler_jobs[ctx->tiler_job_count] = jd;
-        ctx->tiler_jobs[ctx->tiler_job_count++] = tiler.gpu;
         ctx->draw_count++;
 
         /* Okay, so we have the tiler job emitted. Since we set elided_tiler