d3dadapter9: Revert to old throttling limit value

Submitted by Axel Davy on May 30, 2019, 10:43 a.m.

Details

Message ID 2bcf69df-007f-2ece-6f3c-5cf1835a1e3d@gmail.com
State New
Headers show
Series "d3dadapter9: Revert to old throttling limit value" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Axel Davy May 30, 2019, 10:43 a.m.
Thanks Juan for warning me it didn't make it to mesa-dev.
Here it is.


Axel

-------- Forwarded Message --------
Subject: 	[PATCH] d3dadapter9: Revert to old throttling limit value
Date: 	Sun, 26 May 2019 23:23:59 +0200
From: 	Axel Davy <davyaxel0@gmail.com>
CC: 	Axel Davy <davyaxel0@gmail.com>, mesa-stable@lists.freedesktop.org



Recently PIPE_CAP_MAX_FRAMES_IN_FLIGHT was changed from 2
to 1:
20909284f204091757c050aa40cfffaf3f981b9c

No driver seems to overwrite the default value.

One user reports severe regressions for some games.
For now, revert to the value 2 for nine.

Cc: mesa-stable@lists.freedesktop.org

Signed-off-by: Axel Davy <davyaxel0@gmail.com>
---
src/gallium/targets/d3dadapter9/drm.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/gallium/targets/d3dadapter9/drm.c 
b/src/gallium/targets/d3dadapter9/drm.c
index b0b9bb12f2c..657c619ac42 100644
--- a/src/gallium/targets/d3dadapter9/drm.c
+++ b/src/gallium/targets/d3dadapter9/drm.c
@@ -243,8 +243,10 @@  drm_create_adapter( int fd,
return D3DERR_DRIVERINTERNALERROR;
}
- ctx->base.throttling_value =
- ctx->base.hal->get_param(ctx->base.hal, PIPE_CAP_MAX_FRAMES_IN_FLIGHT);
+ /* Previously was set to PIPE_CAP_MAX_FRAMES_IN_FLIGHT,
+ * but the change of value of this cap to 1 seems to cause
+ * regressions. */
+ ctx->base.throttling_value = 2;
ctx->base.throttling = ctx->base.throttling_value > 0;
driParseOptionInfo(&defaultInitOptions, __driConfigOptionsNine);

-- 
2.21.0

Comments