[phodav,01/13] spice: remove G_SOURCE_{REMOVE, CONTINUE} definitions

Submitted by Jakub Janku on May 23, 2019, 8:37 a.m.

Details

Message ID 20190523083725.1554-2-jjanku@redhat.com
State New
Headers show
Series "Miscellaneous series" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Jakub Janku May 23, 2019, 8:37 a.m.
Other symbols that were added after G_SOURCE_{REMOVE, CONTINUE}
are already being used in the rest of the file - e.g. g_task_new,
so there's no need to define these.

Signed-off-by: Jakub Janků <jjanku@redhat.com>
---
 spice/spice-webdavd.c | 7 -------
 1 file changed, 7 deletions(-)

Patch hide | download patch | download mbox

diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c
index cd0029b..81fe6be 100644
--- a/spice/spice-webdavd.c
+++ b/spice/spice-webdavd.c
@@ -665,13 +665,6 @@  mdns_state_changed (GaClient *client, GaClientState state, gpointer user_data)
 }
 #endif
 
-#ifndef G_SOURCE_REMOVE
-#define G_SOURCE_REMOVE FALSE
-#endif
-#ifndef G_SOURCE_CONTINUE
-#define G_SOURCE_CONTINUE TRUE
-#endif
-
 #ifdef G_OS_UNIX
 static void
 wait_for_virtio_host (gint fd)

Comments

On Thu, May 23, 2019 at 10:37 AM Jakub Janků <jjanku@redhat.com> wrote:
>
> Other symbols that were added after G_SOURCE_{REMOVE, CONTINUE}
> are already being used in the rest of the file - e.g. g_task_new,
> so there's no need to define these.
>
> Signed-off-by: Jakub Janků <jjanku@redhat.com>

ack,
we should bump glib dep to 2.36 at least (gtask)

> ---
>  spice/spice-webdavd.c | 7 -------
>  1 file changed, 7 deletions(-)
>
> diff --git a/spice/spice-webdavd.c b/spice/spice-webdavd.c
> index cd0029b..81fe6be 100644
> --- a/spice/spice-webdavd.c
> +++ b/spice/spice-webdavd.c
> @@ -665,13 +665,6 @@ mdns_state_changed (GaClient *client, GaClientState state, gpointer user_data)
>  }
>  #endif
>
> -#ifndef G_SOURCE_REMOVE
> -#define G_SOURCE_REMOVE FALSE
> -#endif
> -#ifndef G_SOURCE_CONTINUE
> -#define G_SOURCE_CONTINUE TRUE
> -#endif
> -
>  #ifdef G_OS_UNIX
>  static void
>  wait_for_virtio_host (gint fd)
> --
> 2.21.0
>
> _______________________________________________
> Spice-devel mailing list
> Spice-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/spice-devel