[1/5] vmwgfx: drop empty lastclose stub

Submitted by Emil Velikov on May 22, 2019, 4:41 p.m.

Details

Message ID 20190522164119.24139-1-emil.l.velikov@gmail.com
State Accepted
Headers show
Series "Series without cover letter" ( rev: 1 ) in DRI devel

Not browsing as part of any series.

Commit Message

Emil Velikov May 22, 2019, 4:41 p.m.
From: Emil Velikov <emil.velikov@collabora.com>

Core DRM is safe when the callback is NULL.

Cc: "VMware Graphics" <linux-graphics-maintainer@vmware.com>
Cc: Thomas Hellstrom <thellstrom@vmware.com>
Cc: Daniel Vetter <daniel@ffwll.ch>
Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
---
 drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 5 -----
 1 file changed, 5 deletions(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
index be25ce9440ad..a38f06909fb6 100644
--- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
+++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c
@@ -1200,10 +1200,6 @@  static long vmw_compat_ioctl(struct file *filp, unsigned int cmd,
 }
 #endif
 
-static void vmw_lastclose(struct drm_device *dev)
-{
-}
-
 static void vmw_master_init(struct vmw_master *vmaster)
 {
 	ttm_lock_init(&vmaster->lock);
@@ -1568,7 +1564,6 @@  static struct drm_driver driver = {
 	DRIVER_MODESET | DRIVER_PRIME | DRIVER_RENDER | DRIVER_ATOMIC,
 	.load = vmw_driver_load,
 	.unload = vmw_driver_unload,
-	.lastclose = vmw_lastclose,
 	.get_vblank_counter = vmw_get_vblank_counter,
 	.enable_vblank = vmw_enable_vblank,
 	.disable_vblank = vmw_disable_vblank,

Comments

On Wed, 2019-05-22 at 17:41 +0100, Emil Velikov wrote:
> From: Emil Velikov <emil.velikov@collabora.com>

> 

> Core DRM is safe when the callback is NULL.

> 

> Cc: "VMware Graphics" <linux-graphics-maintainer@vmware.com>

> Cc: Thomas Hellstrom <thellstrom@vmware.com>

> Cc: Daniel Vetter <daniel@ffwll.ch>

> Signed-off-by: Emil Velikov <emil.velikov@collabora.com>


Reviewed-by: Thomas Hellstrom <thellstrom@vmware.com>



> ---

>  drivers/gpu/drm/vmwgfx/vmwgfx_drv.c | 5 -----

>  1 file changed, 5 deletions(-)

> 

> diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

> b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

> index be25ce9440ad..a38f06909fb6 100644

> --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

> +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c

> @@ -1200,10 +1200,6 @@ static long vmw_compat_ioctl(struct file

> *filp, unsigned int cmd,

>  }

>  #endif

>  

> -static void vmw_lastclose(struct drm_device *dev)

> -{

> -}

> -

>  static void vmw_master_init(struct vmw_master *vmaster)

>  {

>  	ttm_lock_init(&vmaster->lock);

> @@ -1568,7 +1564,6 @@ static struct drm_driver driver = {

>  	DRIVER_MODESET | DRIVER_PRIME | DRIVER_RENDER | DRIVER_ATOMIC,

>  	.load = vmw_driver_load,

>  	.unload = vmw_driver_unload,

> -	.lastclose = vmw_lastclose,

>  	.get_vblank_counter = vmw_get_vblank_counter,

>  	.enable_vblank = vmw_enable_vblank,

>  	.disable_vblank = vmw_disable_vblank,