[libdrm,1/7] addr cs chunk for syncobj timeline

Submitted by Chunming Zhou on May 13, 2019, 9:52 a.m.

Details

Message ID 20190513095305.14110-1-david1.zhou@amd.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in AMD X.Org drivers

Not browsing as part of any series.

Commit Message

Chunming Zhou May 13, 2019, 9:52 a.m.
Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
---
 include/drm/amdgpu_drm.h | 9 +++++++++
 1 file changed, 9 insertions(+)

Patch hide | download patch | download mbox

diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
index d0701ffc..3d0318e6 100644
--- a/include/drm/amdgpu_drm.h
+++ b/include/drm/amdgpu_drm.h
@@ -528,6 +528,8 @@  struct drm_amdgpu_gem_va {
 #define AMDGPU_CHUNK_ID_SYNCOBJ_OUT     0x05
 #define AMDGPU_CHUNK_ID_BO_HANDLES      0x06
 #define AMDGPU_CHUNK_ID_SCHEDULED_DEPENDENCIES	0x07
+#define AMDGPU_CHUNK_ID_SYNCOBJ_TIMELINE_WAIT    0x08
+#define AMDGPU_CHUNK_ID_SYNCOBJ_TIMELINE_SIGNAL  0x09
 
 struct drm_amdgpu_cs_chunk {
 	__u32		chunk_id;
@@ -608,6 +610,13 @@  struct drm_amdgpu_cs_chunk_sem {
 	__u32 handle;
 };
 
+struct drm_amdgpu_cs_chunk_syncobj {
+	__u32 handle;
+	__u32 flags;
+	__u64 point;
+};
+
+
 #define AMDGPU_FENCE_TO_HANDLE_GET_SYNCOBJ	0
 #define AMDGPU_FENCE_TO_HANDLE_GET_SYNCOBJ_FD	1
 #define AMDGPU_FENCE_TO_HANDLE_GET_SYNC_FILE_FD	2

Comments

ping... for patch set.


On 2019年05月13日 17:52, Chunming Zhou wrote:
> [CAUTION: External Email]
>
> Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
> ---
>   include/drm/amdgpu_drm.h | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
> index d0701ffc..3d0318e6 100644
> --- a/include/drm/amdgpu_drm.h
> +++ b/include/drm/amdgpu_drm.h
> @@ -528,6 +528,8 @@ struct drm_amdgpu_gem_va {
>   #define AMDGPU_CHUNK_ID_SYNCOBJ_OUT     0x05
>   #define AMDGPU_CHUNK_ID_BO_HANDLES      0x06
>   #define AMDGPU_CHUNK_ID_SCHEDULED_DEPENDENCIES 0x07
> +#define AMDGPU_CHUNK_ID_SYNCOBJ_TIMELINE_WAIT    0x08
> +#define AMDGPU_CHUNK_ID_SYNCOBJ_TIMELINE_SIGNAL  0x09
>
>   struct drm_amdgpu_cs_chunk {
>          __u32           chunk_id;
> @@ -608,6 +610,13 @@ struct drm_amdgpu_cs_chunk_sem {
>          __u32 handle;
>   };
>
> +struct drm_amdgpu_cs_chunk_syncobj {
> +       __u32 handle;
> +       __u32 flags;
> +       __u64 point;
> +};
> +
> +
>   #define AMDGPU_FENCE_TO_HANDLE_GET_SYNCOBJ     0
>   #define AMDGPU_FENCE_TO_HANDLE_GET_SYNCOBJ_FD  1
>   #define AMDGPU_FENCE_TO_HANDLE_GET_SYNC_FILE_FD        2
> --
> 2.17.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
Sorry for the delay, I'll try to review this tomorrow.

-Lionel

On 13/05/2019 11:15, zhoucm1 wrote:
> ping... for patch set.
>
>
> On 2019年05月13日 17:52, Chunming Zhou wrote:
>> [CAUTION: External Email]
>>
>> Signed-off-by: Chunming Zhou <david1.zhou@amd.com>
>> ---
>>   include/drm/amdgpu_drm.h | 9 +++++++++
>>   1 file changed, 9 insertions(+)
>>
>> diff --git a/include/drm/amdgpu_drm.h b/include/drm/amdgpu_drm.h
>> index d0701ffc..3d0318e6 100644
>> --- a/include/drm/amdgpu_drm.h
>> +++ b/include/drm/amdgpu_drm.h
>> @@ -528,6 +528,8 @@ struct drm_amdgpu_gem_va {
>>   #define AMDGPU_CHUNK_ID_SYNCOBJ_OUT     0x05
>>   #define AMDGPU_CHUNK_ID_BO_HANDLES      0x06
>>   #define AMDGPU_CHUNK_ID_SCHEDULED_DEPENDENCIES 0x07
>> +#define AMDGPU_CHUNK_ID_SYNCOBJ_TIMELINE_WAIT    0x08
>> +#define AMDGPU_CHUNK_ID_SYNCOBJ_TIMELINE_SIGNAL  0x09
>>
>>   struct drm_amdgpu_cs_chunk {
>>          __u32           chunk_id;
>> @@ -608,6 +610,13 @@ struct drm_amdgpu_cs_chunk_sem {
>>          __u32 handle;
>>   };
>>
>> +struct drm_amdgpu_cs_chunk_syncobj {
>> +       __u32 handle;
>> +       __u32 flags;
>> +       __u64 point;
>> +};
>> +
>> +
>>   #define AMDGPU_FENCE_TO_HANDLE_GET_SYNCOBJ     0
>>   #define AMDGPU_FENCE_TO_HANDLE_GET_SYNCOBJ_FD  1
>>   #define AMDGPU_FENCE_TO_HANDLE_GET_SYNC_FILE_FD        2
>> -- 
>> 2.17.1
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx@lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
>
With the small nits, patches 2 & 4 are : Reviewed-by: Lionel Landwerlin 
<lionel.g.landwerlin@intel.com>
The other patches are a bit amdgpu specific so maybe you might want 
someone more familiar with amdgpu to review them.
Still I didn't see anything wrong with them so remaining patches are : 
Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>

I'll send the IGT stuff shortly.

Thanks,

-Lionel
Thank you, Lionel.

-David


On 2019年05月14日 17:49, Lionel Landwerlin wrote:
> [CAUTION: External Email]
>
> With the small nits, patches 2 & 4 are : Reviewed-by: Lionel Landwerlin
> <lionel.g.landwerlin@intel.com>
> The other patches are a bit amdgpu specific so maybe you might want
> someone more familiar with amdgpu to review them.
> Still I didn't see anything wrong with them so remaining patches are :
> Acked-by: Lionel Landwerlin <lionel.g.landwerlin@intel.com>
>
> I'll send the IGT stuff shortly.
>
> Thanks,
>
> -Lionel