[spice-gtk,v1,1/2] channel-webdav: avoid possible crash

Submitted by Victor Toso on May 6, 2019, 10:31 a.m.

Details

Message ID 20190506103156.14925-1-victortoso@redhat.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Spice

Not browsing as part of any series.

Commit Message

Victor Toso May 6, 2019, 10:31 a.m.
From: Victor Toso <me@victortoso.com>

In case PhodavServer or SoupServer are NULL, we should stop and
return.

Signed-off-by: Victor Toso <victortoso@redhat.com>
---
 src/channel-webdav.c | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/src/channel-webdav.c b/src/channel-webdav.c
index 8e4db1a..195ae34 100644
--- a/src/channel-webdav.c
+++ b/src/channel-webdav.c
@@ -355,12 +355,17 @@  static void start_client(SpiceWebdavChannel *self)
     GIOStream *peer = NULL;
     SpiceSession *session;
     SoupServer *server;
+    PhodavServer* phodav_server;
     GSocketAddress *addr;
     GError *error = NULL;
     bool started;
 
     session = spice_channel_get_session(SPICE_CHANNEL(self));
-    server = phodav_server_get_soup_server(spice_session_get_webdav_server(session));
+    phodav_server = spice_session_get_webdav_server(session);
+    g_return_if_fail(phodav_server != NULL);
+
+    server = phodav_server_get_soup_server(phodav_server);
+    g_return_if_fail(server != NULL);
 
     CHANNEL_DEBUG(self, "starting client %" G_GINT64_FORMAT, c->demux.client);