[v10,03/11] bluetooth: Update TODO: about tstamp in a2dp_process_push()

Submitted by Pali Rohár on May 3, 2019, 9:05 p.m.

Details

Message ID 20190503210523.30636-4-pali.rohar@gmail.com
State Superseded
Headers show
Series "New API for Bluetooth A2DP codecs" ( rev: 73 72 71 70 69 68 67 66 65 64 63 ) in PulseAudio

Not browsing as part of any series.

Commit Message

Pali Rohár May 3, 2019, 9:05 p.m.
tstamp is local time when packet was received -- not remote time when packet was sent.
---
 src/modules/bluetooth/module-bluez5-device.c | 8 ++------
 1 file changed, 2 insertions(+), 6 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/modules/bluetooth/module-bluez5-device.c b/src/modules/bluetooth/module-bluez5-device.c
index c0b293d94..08de1154b 100644
--- a/src/modules/bluetooth/module-bluez5-device.c
+++ b/src/modules/bluetooth/module-bluez5-device.c
@@ -536,7 +536,6 @@  static int a2dp_process_push(struct userdata *u) {
     memchunk.index = memchunk.length = 0;
 
     for (;;) {
-        bool found_tstamp = false;
         pa_usec_t tstamp;
         uint8_t *ptr;
         ssize_t l;
@@ -563,11 +562,8 @@  static int a2dp_process_push(struct userdata *u) {
 
         pa_assert((size_t) l <= u->decoder_buffer_size);
 
-        /* TODO: get timestamp from rtp */
-        if (!found_tstamp) {
-            /* pa_log_warn("Couldn't find SO_TIMESTAMP data in auxiliary recvmsg() data!"); */
-            tstamp = pa_rtclock_now();
-        }
+        /* TODO: retrieve SO_TIMESTAMP, local tstamp for received bluz packet from u->stream_fd socket */
+        tstamp = pa_rtclock_now();
 
         ptr = pa_memblock_acquire(memchunk.memblock);
         memchunk.length = pa_memblock_get_length(memchunk.memblock);