suggestion to move test/font-variantions.c from test_sources to ft_font_test_sources

Submitted by suzuki toshiya on April 7, 2019, 7:14 a.m.

Details

Message ID 5CA99FB3.6050309@hiroshima-u.ac.jp
State New
Headers show
Series "suggestion to move test/font-variantions.c from test_sources to ft_font_test_sources" ( rev: 1 ) in Cairo

Not browsing as part of any series.

Commit Message

suzuki toshiya April 7, 2019, 7:14 a.m.
Hi,

Recently I've tried to build cairo without FreeType2 and fontconfig
on GNU/Linux, by disabling them. I found that test/font-variations.c
is still tried to be built (and failed if there is no FreeType2
really).

Although I accept such configuration (not font backend configuration)
is very irregular and the result would not be practically useful,
I suggest to move the classification of font-variations.c from
test_sources (which would be built regardless with the availability
of font backend) to ft_font_test_sources (which would be built if
FreeType2 font backend is available). My patch (to git head) is
attached.

Regards,
mpsuzuki

Patch hide | download patch | download mbox

diff --git a/test/Makefile.sources b/test/Makefile.sources
index c47131faf..cc3d81f7e 100644
--- a/test/Makefile.sources
+++ b/test/Makefile.sources
@@ -144,7 +144,6 @@  test_sources = \
 	font-face-get-type.c				\
 	font-matrix-translation.c			\
 	font-options.c					\
-	font-variations.c				\
 	glyph-cache-pressure.c				\
 	get-and-set.c					\
 	get-clip.c					\
@@ -399,6 +398,7 @@  pthread_test_sources =					\
 
 ft_font_test_sources = \
 	bitmap-font.c \
+	font-variations.c \
 	ft-font-create-for-ft-face.c \
 	ft-show-glyphs-positioning.c \
 	ft-show-glyphs-table.c \

Comments

On Sun, Apr 7, 2019 at 9:14 AM suzuki toshiya
<mpsuzuki@hiroshima-u.ac.jp> wrote:
>
> Hi,

Hi,

note that cairo now uses gitlab for bug reports and patches.
Please consider creating merge requests at
https://gitlab.freedesktop.org/cairo/cairo/merge_requests
Hi,

Thank you for reminding the current development style of Cairo.
Just I've made 2 MRs.

https://gitlab.freedesktop.org/cairo/cairo/merge_requests/22
https://gitlab.freedesktop.org/cairo/cairo/merge_requests/23

Thanks in advance!

mpsuzuki

Christoph Reiter wrote:
> On Sun, Apr 7, 2019 at 9:14 AM suzuki toshiya
> <mpsuzuki@hiroshima-u.ac.jp> wrote:
>> Hi,
> 
> Hi,
> 
> note that cairo now uses gitlab for bug reports and patches.
> Please consider creating merge requests at
> https://jpn01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgitlab.freedesktop.org%2Fcairo%2Fcairo%2Fmerge_requests&amp;data=02%7C01%7Cmpsuzuki%40hiroshima-u.ac.jp%7Cef277f223cd14194199c08d6bb396d28%7Cc40454ddb2634926868d8e12640d3750%7C1%7C1%7C636902252645497018&amp;sdata=pWOMqQe1ipT3rohW7UgQos3r5RfspSNKudsedxdpzh4%3D&amp;reserved=0
>