[3/3] gallium/auxiliary/vl: Add barrier/unbind after compute shader launch.

Submitted by Zhu, James on April 2, 2019, 6:21 p.m.

Details

Message ID 1554229310-11150-3-git-send-email-James.Zhu@amd.com
State New
Headers show
Series "Series without cover letter" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Zhu, James April 2, 2019, 6:21 p.m.
Add memory barrier sync and unbind resource after launch will enhance
the robustness.

Signed-off-by: James Zhu <James.Zhu@amd.com>
---
 src/gallium/auxiliary/vl/vl_compositor_cs.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

Patch hide | download patch | download mbox

diff --git a/src/gallium/auxiliary/vl/vl_compositor_cs.c b/src/gallium/auxiliary/vl/vl_compositor_cs.c
index c3afe61..f00cb65 100644
--- a/src/gallium/auxiliary/vl/vl_compositor_cs.c
+++ b/src/gallium/auxiliary/vl/vl_compositor_cs.c
@@ -292,6 +292,17 @@  cs_launch(struct vl_compositor *c,
    info.grid[2] = 1;
 
    ctx->launch_grid(ctx, &info);
+
+   /* Make the result visible to all clients. */
+   ctx->memory_barrier(ctx, PIPE_BARRIER_ALL);
+
+   /* Unbind. */
+   ctx->set_shader_images(ctx, PIPE_SHADER_COMPUTE, 0, 1, NULL);
+   ctx->set_constant_buffer(ctx, PIPE_SHADER_COMPUTE, 0, NULL);
+   ctx->set_sampler_views(c->pipe, PIPE_SHADER_FRAGMENT, 0, 0, NULL);
+   ctx->bind_compute_state(ctx, NULL);
+   ctx->bind_sampler_states(c->pipe, PIPE_SHADER_COMPUTE, 0, 0, NULL);
+   ctx->flush(ctx, NULL, 0);
 }
 
 static inline struct u_rect

Comments


On Tue, Apr 2, 2019 at 2:22 PM Zhu, James <James.Zhu@amd.com> wrote:
>
> Add memory barrier sync and unbind resource after launch will enhance
> the robustness.

I can't tell from the comment -- is this working around driver bugs,
or is the state tracker using the API incorrectly and this fixes the
usage. If the latter, what was incorrect?

I don't think "enhance robustness" without a description of how is a
sufficient description.

  -ilia