[3/3] drm/i915/bios: parse ddi ports also on VLV

Submitted by Jani Nikula on March 6, 2019, 3:34 p.m.

Details

Message ID 00a286df2820145d454378bc20a91d860c1ae9e8.1551886309.git.jani.nikula@intel.com
State New
Headers show
Series "drm/i915/bios: ddi port parsing changes" ( rev: 1 ) in Intel GFX

Not browsing as part of any series.

Commit Message

Jani Nikula March 6, 2019, 3:34 p.m.
The main benefit is improved debug logging of the ports also on VLV.

Signed-off-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/intel_bios.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
index 9beff569b010..030a5e9c67b3 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -1514,7 +1514,8 @@  static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version)
 	const struct child_device_config *child;
 	int i;
 
-	if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv))
+	if (!HAS_DDI(dev_priv) &&
+	    !IS_CHERRYVIEW(dev_priv) && !IS_VALLEYVIEW(dev_priv))
 		return;
 
 	if (bdb_version < 155)

Comments

On Wed, Mar 06, 2019 at 05:34:16PM +0200, Jani Nikula wrote:
> The main benefit is improved debug logging of the ports also on VLV.

The fact that this causes VLV to start using the AUX/DDC pins from VBT
needs to be called out in the commit msg.

> 
> Signed-off-by: Jani Nikula <jani.nikula@intel.com>
> ---
>  drivers/gpu/drm/i915/intel_bios.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/intel_bios.c b/drivers/gpu/drm/i915/intel_bios.c
> index 9beff569b010..030a5e9c67b3 100644
> --- a/drivers/gpu/drm/i915/intel_bios.c
> +++ b/drivers/gpu/drm/i915/intel_bios.c
> @@ -1514,7 +1514,8 @@ static void parse_ddi_ports(struct drm_i915_private *dev_priv, u8 bdb_version)
>  	const struct child_device_config *child;
>  	int i;
>  
> -	if (!HAS_DDI(dev_priv) && !IS_CHERRYVIEW(dev_priv))
> +	if (!HAS_DDI(dev_priv) &&
> +	    !IS_CHERRYVIEW(dev_priv) && !IS_VALLEYVIEW(dev_priv))
>  		return;
>  
>  	if (bdb_version < 155)
> -- 
> 2.20.1