panfrost: Flush with offscreen rendering

Submitted by Alyssa Rosenzweig on Feb. 27, 2019, 3:44 a.m.

Details

Message ID 20190227034405.9495-1-alyssa@rosenzweig.io
State New
Headers show
Series "panfrost: Flush with offscreen rendering" ( rev: 1 ) in Mesa

Not browsing as part of any series.

Commit Message

Alyssa Rosenzweig Feb. 27, 2019, 3:44 a.m.
This special-case was needlessly added and breaks purely offscreen
rendering (when there is no scanout involved).

Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
---
 src/gallium/drivers/panfrost/pan_context.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c
index 9c0f0420e2b..e20bf25d97d 100644
--- a/src/gallium/drivers/panfrost/pan_context.c
+++ b/src/gallium/drivers/panfrost/pan_context.c
@@ -1576,14 +1576,14 @@  panfrost_submit_frame(struct panfrost_context *ctx, bool flush_immediate)
 
         /* If visual, we can stall a frame */
 
-        if (panfrost_is_scanout(ctx) && !flush_immediate)
+        if (!flush_immediate)
                 screen->driver->force_flush_fragment(ctx);
 
         screen->last_fragment_id = fragment_id;
         screen->last_fragment_flushed = false;
 
         /* If readback, flush now (hurts the pipelined performance) */
-        if (panfrost_is_scanout(ctx) && flush_immediate)
+        if (flush_immediate)
                 screen->driver->force_flush_fragment(ctx);
 
 #ifdef DUMP_PERFORMANCE_COUNTERS

Comments

Reviewed-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>

Thanks,

Tomeu

On Wed, 27 Feb 2019 at 04:44, Alyssa Rosenzweig <alyssa@rosenzweig.io> wrote:
>
> This special-case was needlessly added and breaks purely offscreen
> rendering (when there is no scanout involved).
>
> Signed-off-by: Alyssa Rosenzweig <alyssa@rosenzweig.io>
> ---
>  src/gallium/drivers/panfrost/pan_context.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c
> index 9c0f0420e2b..e20bf25d97d 100644
> --- a/src/gallium/drivers/panfrost/pan_context.c
> +++ b/src/gallium/drivers/panfrost/pan_context.c
> @@ -1576,14 +1576,14 @@ panfrost_submit_frame(struct panfrost_context *ctx, bool flush_immediate)
>
>          /* If visual, we can stall a frame */
>
> -        if (panfrost_is_scanout(ctx) && !flush_immediate)
> +        if (!flush_immediate)
>                  screen->driver->force_flush_fragment(ctx);
>
>          screen->last_fragment_id = fragment_id;
>          screen->last_fragment_flushed = false;
>
>          /* If readback, flush now (hurts the pipelined performance) */
> -        if (panfrost_is_scanout(ctx) && flush_immediate)
> +        if (flush_immediate)
>                  screen->driver->force_flush_fragment(ctx);
>
>  #ifdef DUMP_PERFORMANCE_COUNTERS
> --
> 2.20.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev