[v4,38/40] compiler/spirv: move the check for Int8 capability

Submitted by Iago Toral Quiroga on Feb. 12, 2019, 11:56 a.m.

Details

Message ID 20190212115607.21467-39-itoral@igalia.com
State New
Headers show
Series "intel: VK_KHR_shader_float16_int8 implementation" ( rev: 16 15 14 13 12 11 10 9 8 7 6 ) in Mesa

Not browsing as part of any series.

Commit Message

Iago Toral Quiroga Feb. 12, 2019, 11:56 a.m.
So it is right after the checks for the other various Int* capabilities.
---
 src/compiler/spirv/spirv_to_nir.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c
index 1cbc926c818..7e07de2bfc0 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -3579,6 +3579,9 @@  vtn_handle_preamble_instruction(struct vtn_builder *b, SpvOp opcode,
       case SpvCapabilityInt16:
          spv_check_supported(int16, cap);
          break;
+      case SpvCapabilityInt8:
+         spv_check_supported(int8, cap);
+         break;
 
       case SpvCapabilityTransformFeedback:
          spv_check_supported(transform_feedback, cap);
@@ -3591,10 +3594,6 @@  vtn_handle_preamble_instruction(struct vtn_builder *b, SpvOp opcode,
       case SpvCapabilityInt64Atomics:
          spv_check_supported(int64_atomics, cap);
 
-      case SpvCapabilityInt8:
-         spv_check_supported(int8, cap);
-         break;
-
       case SpvCapabilityStorageImageMultisample:
          spv_check_supported(storage_image_ms, cap);
          break;

Comments

Reviewed-by: Jason Ekstrand <jason@jlekstrand.net>

On Tue, Feb 12, 2019 at 5:56 AM Iago Toral Quiroga <itoral@igalia.com>
wrote:

> So it is right after the checks for the other various Int* capabilities.
> ---
>  src/compiler/spirv/spirv_to_nir.c | 7 +++----
>  1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/src/compiler/spirv/spirv_to_nir.c
> b/src/compiler/spirv/spirv_to_nir.c
> index 1cbc926c818..7e07de2bfc0 100644
> --- a/src/compiler/spirv/spirv_to_nir.c
> +++ b/src/compiler/spirv/spirv_to_nir.c
> @@ -3579,6 +3579,9 @@ vtn_handle_preamble_instruction(struct vtn_builder
> *b, SpvOp opcode,
>        case SpvCapabilityInt16:
>           spv_check_supported(int16, cap);
>           break;
> +      case SpvCapabilityInt8:
> +         spv_check_supported(int8, cap);
> +         break;
>
>        case SpvCapabilityTransformFeedback:
>           spv_check_supported(transform_feedback, cap);
> @@ -3591,10 +3594,6 @@ vtn_handle_preamble_instruction(struct vtn_builder
> *b, SpvOp opcode,
>        case SpvCapabilityInt64Atomics:
>           spv_check_supported(int64_atomics, cap);
>
> -      case SpvCapabilityInt8:
> -         spv_check_supported(int8, cap);
> -         break;
> -
>        case SpvCapabilityStorageImageMultisample:
>           spv_check_supported(storage_image_ms, cap);
>           break;
> --
> 2.17.1
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/mesa-dev