[i-g-t,4/9] tests/gem_exec_reuse: Don't leak the hang detector

Submitted by Daniel Vetter on Feb. 11, 2019, 6:02 p.m.

Details

Message ID 20190211180208.29406-4-daniel.vetter@ffwll.ch
State Accepted
Series "Series without cover letter"
Commit 3e841ea25912de4fb6c7b91da33a6912adb0dfc1
Headers show

Commit Message

Daniel Vetter Feb. 11, 2019, 6:02 p.m.
My new "are there any child processes left?" check in igt_exit catched
this one.

Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 tests/i915/gem_exec_reuse.c | 3 +++
 1 file changed, 3 insertions(+)

Patch hide | download patch | download mbox

diff --git a/tests/i915/gem_exec_reuse.c b/tests/i915/gem_exec_reuse.c
index df220be7bab8..559047188fbd 100644
--- a/tests/i915/gem_exec_reuse.c
+++ b/tests/i915/gem_exec_reuse.c
@@ -213,4 +213,7 @@  igt_main
 		for (n = 0; n < ncontexts; n++)
 			gem_context_destroy(no.fd, contexts[n]);
 	}
+
+	igt_fixture
+		igt_stop_hang_detector();
 }

Comments

Chris Wilson Feb. 11, 2019, 6:06 p.m.
Quoting Daniel Vetter (2019-02-11 18:02:03)
> My new "are there any child processes left?" check in igt_exit catched
> this one.
> 
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  tests/i915/gem_exec_reuse.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/i915/gem_exec_reuse.c b/tests/i915/gem_exec_reuse.c
> index df220be7bab8..559047188fbd 100644
> --- a/tests/i915/gem_exec_reuse.c
> +++ b/tests/i915/gem_exec_reuse.c
> @@ -213,4 +213,7 @@ igt_main
>                 for (n = 0; n < ncontexts; n++)
>                         gem_context_destroy(no.fd, contexts[n]);
>         }
> +
> +       igt_fixture
> +               igt_stop_hang_detector();

Better than my attempt which didn't remember it took void.
Reviewed-by: Chris Wilson <chris@chris-wilson.co.uk>
-Chris