[xf86-video-savage] Disable EXA acceleration for now

Submitted by Kevin Brace on Feb. 11, 2019, 5:02 p.m.

Details

Message ID 1549904535-8546-2-git-send-email-kevinbrace@gmx.com
State New
Headers show
Series "Disable EXA acceleration for now" ( rev: 1 ) in X.org

Not browsing as part of any series.

Commit Message

Kevin Brace Feb. 11, 2019, 5:02 p.m.
EXA acceleration architecture code is currently broken on X Server
1.19, so it should be disabled until it is fixed.

Signed-off-by: Kevin Brace <kevinbrace@gmx.com>
---
 src/savage_driver.c | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

Patch hide | download patch | download mbox

diff --git a/src/savage_driver.c b/src/savage_driver.c
index 01fc0bc..e26b0f1 100644
--- a/src/savage_driver.c
+++ b/src/savage_driver.c
@@ -1273,14 +1273,29 @@  static Bool SavagePreInit(ScrnInfoPtr pScrn, int flags)
 	        psav->useEXA = FALSE;
 	    } else if(!xf86NameCmp(strptr,"EXA")) {
 	       from = X_CONFIG;
-	       psav->useEXA = TRUE;
+	       psav->NoAccel = TRUE;
+	       psav->useEXA = FALSE;
+	       xf86DrvMsg(pScrn->scrnIndex, X_INFO,
+	                   "EXA acceleration architecture is "
+	                   "permanently disabled for this version.\n");
 	    }
         }
 #else
-	psav->useEXA = TRUE;
+	psav->NoAccel = TRUE;
+	psav->useEXA = FALSE;
+	xf86DrvMsg(pScrn->scrnIndex, X_INFO,
+	            "EXA acceleration architecture is "
+	            "permanently disabled for this version.\n");
 #endif
-       xf86DrvMsg(pScrn->scrnIndex, from, "Using %s acceleration architecture\n",
-		psav->useEXA ? "EXA" : "XAA");
+
+	if (!psav->NoAccel) {
+	    xf86DrvMsg(pScrn->scrnIndex, from,
+	                "Using %s acceleration architecture\n",
+	                psav->useEXA ? "EXA" : "XAA");
+	} else {
+	    xf86DrvMsg(pScrn->scrnIndex, X_INFO,
+	                "Hardware acceleration is disabled.\n");
+	}
     }
 
     if ((s = xf86GetOptValString(psav->Options, OPTION_OVERLAY))) {

Comments

On 2019-02-11 12:02 PM, Kevin Brace wrote:
> EXA acceleration architecture code is currently broken on X Server
> 1.19, so it should be disabled until it is fixed.
>
> Signed-off-by: Kevin Brace <kevinbrace@gmx.com>
> ---
>  src/savage_driver.c | 23 +++++++++++++++++++----
>  1 file changed, 19 insertions(+), 4 deletions(-)
Is this because the rendering is wrong? Or does the X server crash
before you can test?
> diff --git a/src/savage_driver.c b/src/savage_driver.c
> index 01fc0bc..e26b0f1 100644
> --- a/src/savage_driver.c
> +++ b/src/savage_driver.c
> @@ -1273,14 +1273,29 @@ static Bool SavagePreInit(ScrnInfoPtr pScrn, int flags)
>  	        psav->useEXA = FALSE;
>  	    } else if(!xf86NameCmp(strptr,"EXA")) {
>  	       from = X_CONFIG;
> -	       psav->useEXA = TRUE;
> +	       psav->NoAccel = TRUE;
> +	       psav->useEXA = FALSE;
> +	       xf86DrvMsg(pScrn->scrnIndex, X_INFO,
> +	                   "EXA acceleration architecture is "
> +	                   "permanently disabled for this version.\n");
>  	    }
>          }
>  #else
> -	psav->useEXA = TRUE;
> +	psav->NoAccel = TRUE;
> +	psav->useEXA = FALSE;
> +	xf86DrvMsg(pScrn->scrnIndex, X_INFO,
> +	            "EXA acceleration architecture is "
> +	            "permanently disabled for this version.\n");
>  #endif
> -       xf86DrvMsg(pScrn->scrnIndex, from, "Using %s acceleration architecture\n",
> -		psav->useEXA ? "EXA" : "XAA");
> +
> +	if (!psav->NoAccel) {
> +	    xf86DrvMsg(pScrn->scrnIndex, from,
> +	                "Using %s acceleration architecture\n",
> +	                psav->useEXA ? "EXA" : "XAA");
> +	} else {
> +	    xf86DrvMsg(pScrn->scrnIndex, X_INFO,
> +	                "Hardware acceleration is disabled.\n");
> +	}
>      }
>  
>      if ((s = xf86GetOptValString(psav->Options, OPTION_OVERLAY))) {