BUG - unable to handle null pointer, bisected - drm/amd/display: add gpio lock/unlock

Submitted by Przemek Socha on Feb. 7, 2019, 10:15 p.m.

Details

Message ID 1970276.ZfjSEdBXdN@eclipse
State New
Series "BUG - unable to handle null pointer, bisected - drm/amd/display: add gpio lock/unlock"
Headers show

Commit Message

Przemek Socha Feb. 7, 2019, 10:15 p.m.
Dnia czwartek, 7 lutego 2019 22:59:59 CET piszesz:

> > I'll post a fix shortly.
> 
> Fix merged to amd-staging-drm-next.
> 
> Harry
> 


I apologize for the late response, 
and thank you very much.

I had a problem with applying the patch on top of clean amd-staging-drm-next 
because it is in one chunk,  I suppose ( but my patch-fu could be weak also) I 
had t o modify it like this:
"
 	switch (link->link_id.id) {
 	case CONNECTOR_ID_HDMI_TYPE_A:
"

After that, machine works as it should.

So this patch also works on Mullins apu.

Once again, thank you all very much.

Przemek.

Patch hide | download patch | download mbox

--- a/drivers/gpu/drm/amd/display/dc/core/dc_link.c
+++ b/drivers/gpu/drm/amd/display/dc/core/dc_link.c
@@ -1127,10 +1127,11 @@ 
 		link->dc->res_pool->funcs->link_init(link);
 
 	link->hpd_gpio = get_hpd_gpio(link->ctx->dc_bios, link->link_id, 
link->ctx->gpio_service);
-	dal_gpio_open(link->hpd_gpio, GPIO_MODE_INTERRUPT);
-	dal_gpio_unlock_pin(link->hpd_gpio);
-	if (link->hpd_gpio != NULL)
-		link->irq_source_hpd = dal_irq_get_source(link-
>hpd_gpio);
+if (link->hpd_gpio != NULL) {
+               dal_gpio_open(link->hpd_gpio, GPIO_MODE_INTERRUPT);
+               dal_gpio_unlock_pin(link->hpd_gpio);
+                link->irq_source_hpd = dal_irq_get_source(link->hpd_gpio);
+       }