Accept and ignore -g (rather than failing)

Submitted by Rebecca N. Palmer on Feb. 7, 2019, 7:09 p.m.

Details

Message ID 4cc029dd-6d8c-6d75-9a32-da76e071ce8c@zoho.com
State New
Headers show
Series "Accept and ignore -g (rather than failing)" ( rev: 1 ) in Beignet

Not browsing as part of any series.

Commit Message

Rebecca N. Palmer Feb. 7, 2019, 7:09 p.m.
Passing -g through to LLVM fails the build, which violates the OpenCL 
2.0 standard, and breaks at least clblas stable: 
https://bugs.debian.org/881054

Signed-off-by: Rebecca N. Palmer <rebecca_palmer@zoho.com>

Patch hide | download patch | download mbox

--- a/backend/src/backend/program.cpp
+++ b/backend/src/backend/program.cpp
@@ -985,6 +985,12 @@  EXTEND_QUOTE:
            continue; // Don't push this str back; ignore it.
          }

+        if(str == "-g") {
+            // The OpenCL 2.0 standard requires accepting -g,
+            // but does not require that it actually does anything
+            continue;
+        }
+
          clOpt.push_back(str);
        }
        free(c_str);