drm/amd/display: Use context parameters to enable FBC

Submitted by S, Shirish on Feb. 4, 2019, 9:20 a.m.

Details

Message ID 1549272004-30469-1-git-send-email-shirish.s@amd.com
State Accepted
Series "drm/amd/display: Use context parameters to enable FBC"
Commit 12a8bd8862ebd7d6e0f764120e2f322ddc077a11
Headers show

Commit Message

S, Shirish Feb. 4, 2019, 9:20 a.m.
[What]
FBC fails to get enabled when switched between LINEAR(console/VT)
and non-LINEAR(GUI) based rendering due to default value of
tiling info stored in the current_state which is used for deciding
whether or not to turn FBC on or off.

[How]
Use context structure's tiling information which is coherant with
the screen updates.

Signed-off-by: Shirish S <shirish.s@amd.com>
---
 drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch hide | download patch | download mbox

diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
index db0ef41..fd7cd5b 100644
--- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
+++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
@@ -2535,7 +2535,7 @@  static void dce110_apply_ctx_for_surface(
 	}
 
 	if (dc->fbc_compressor)
-		enable_fbc(dc, dc->current_state);
+		enable_fbc(dc, context);
 }
 
 static void dce110_power_down_fe(struct dc *dc, struct pipe_ctx *pipe_ctx)

Comments

Harry Wentland Feb. 4, 2019, 3:55 p.m.
On 2019-02-04 4:20 a.m., S, Shirish wrote:
> [What]

> FBC fails to get enabled when switched between LINEAR(console/VT)

> and non-LINEAR(GUI) based rendering due to default value of

> tiling info stored in the current_state which is used for deciding

> whether or not to turn FBC on or off.

> 

> [How]

> Use context structure's tiling information which is coherant with

> the screen updates.

> 

> Signed-off-by: Shirish S <shirish.s@amd.com>

> ---

>  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 2 +-

>  1 file changed, 1 insertion(+), 1 deletion(-)

> 

> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c

> index db0ef41..fd7cd5b 100644

> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c

> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c

> @@ -2535,7 +2535,7 @@ static void dce110_apply_ctx_for_surface(

>  	}

>  

>  	if (dc->fbc_compressor)

> -		enable_fbc(dc, dc->current_state);

> +		enable_fbc(dc, context);


Looks good, but I'd want Roma's RB.

Acked-by: Harry Wentland <harry.wentland@amd.com>


Harry

>  }

>  

>  static void dce110_power_down_fe(struct dc *dc, struct pipe_ctx *pipe_ctx)

>